[TypeDeclaration] Handle Recursive multiple class string array on Com…

…pleteVarDocTypePropertyRector (#520)

* [TypeDeclaration] Skip Recursive multiple class string array on CompleteVarDocTypePropertyRector

* debug

* fix

* [ci-review] Rector Rectify

Co-authored-by: GitHub Action <action@github.com>

rules-tests/TypeDeclaration/Rector/Property/CompleteVarDocTypePropertyRector/Fixture/recursive_multiple_class_string_array.php.inc

@@ -0,0 +1,60 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\CompleteVarDocTypePropertyRector\Fixture;
+
+class InvokableA {}
+class InvokableB {}
+class InvokableC {}
+class FactoryA {}
+class FactoryB {}
+class FactoryC {}
+
+final class RecursiveMultipleClassStringArray
+{
+    public $services = [
+        'invokables' => [
+            InvokableA::class,
+            InvokableB::class,
+            InvokableC::class,
+        ],
+        'factories' => [
+            FactoryA::class,
+            FactoryB::class,
+            FactoryC::class,
+        ],
+    ];
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Property\CompleteVarDocTypePropertyRector\Fixture;
+
+class InvokableA {}
+class InvokableB {}
+class InvokableC {}
+class FactoryA {}
+class FactoryB {}
+class FactoryC {}
+
+final class RecursiveMultipleClassStringArray
+{
+    /**
+     * @var array<string, mixed[]>
+     */
+    public $services = [
+        'invokables' => [
+            InvokableA::class,
+            InvokableB::class,
+            InvokableC::class,
+        ],
+        'factories' => [
+            FactoryA::class,
+            FactoryB::class,
+            FactoryC::class,
+        ],
+    ];
+}
+
+?>

rules/TypeDeclaration/TypeAnalyzer/GenericClassStringTypeNormalizer.php

@@ -7,6 +7,7 @@
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\ClassStringType;
+use PHPStan\Type\Constant\ConstantArrayType;
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\Generic\GenericClassStringType;
@@ -54,7 +55,7 @@ public function normalize(Type $type): Type
         return $type;
     }
 
-    private function resolveClassStringInUnionType(UnionType $type): Type
+    private function resolveClassStringInUnionType(UnionType $type): UnionType | ArrayType
     {
         $unionTypes = $type->getTypes();
 
@@ -66,6 +67,11 @@ private function resolveClassStringInUnionType(UnionType $type): Type
             $keyType = $unionType->getKeyType();
             $itemType = $unionType->getItemType();
 
+            if ($itemType instanceof ConstantArrayType) {
+                $arrayType = new ArrayType(new MixedType(), new MixedType());
+                return new ArrayType($keyType, $arrayType);
+            }
+
             if (! $keyType instanceof MixedType && ! $keyType instanceof ConstantIntegerType) {
                 return $type;
             }