[DeadCode] Skip append array data on RemoveJustPropertyFetchRector (#…

…3201)

rules-tests/DeadCode/Rector/StmtsAwareInterface/RemoveJustPropertyFetchRector/Fixture/skip_append_array_data.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\StmtsAwareInterface\RemoveJustPropertyFetchRector\Fixture;
+
+final class SkipAppendArrayData
+{
+    private $default = ['some data'];
+
+    public function run()
+    {
+        $where = $this->default;
+        $where[] = 'some append data';
+    }
+}

rules/DeadCode/Rector/StmtsAwareInterface/RemoveJustPropertyFetchRector.php

@@ -22,6 +22,7 @@
 use Rector\Core\Rector\AbstractRector;
 use Rector\DeadCode\ValueObject\PropertyFetchToVariableAssign;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\ReadWrite\NodeAnalyzer\ReadExprAnalyzer;
 use Rector\ReadWrite\NodeFinder\NodeUsageFinder;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -32,7 +33,8 @@
 final class RemoveJustPropertyFetchRector extends AbstractRector
 {
     public function __construct(
-        private readonly NodeUsageFinder $nodeUsageFinder
+        private readonly NodeUsageFinder $nodeUsageFinder,
+        private readonly ReadExprAnalyzer $readExprAnalyzer
     ) {
     }
 
@@ -112,6 +114,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if (! $this->readExprAnalyzer->isExprRead($variableToPropertyAssign->getVariable())) {
+                continue;
+            }
+
             $variableUsages = $this->nodeUsageFinder->findVariableUsages(
                 $followingStmts,
                 $variableToPropertyAssign->getVariable()