[Php74] Handle conflict with alias on TypedPropertyRector (#899)

* [Php74] Handle conflict with alias on TypedPropertyRector

* update

* more conflict example

* update

* update

* Fixed 🎉

* added failing fixture alias never used

* Fixed 🎉

* clean up

* clean up

* union failign test

* Fixed 🎉

* cs fix

* Fixed 🎉

* Fixed 🎉

* skip nullable var union

* more fixtures on use alias only

* final touch: more fixture

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/conflict_with_alias.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias
+{
+    /**
+     * @var Alias
+     */
+    private $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias
+{
+    private Alias $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/conflict_with_alias2.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias2
+{
+    /**
+     * @var AnotherClass
+     */
+    private $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias2
+{
+    private \Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/conflict_with_alias3.php.inc

@@ -0,0 +1,50 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias3
+{
+    /**
+     * @var AnotherClass|\stdClass
+     */
+    private $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+
+    public function setStdClass()
+    {
+        $this->anotherClass = new \stdClass;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias3
+{
+    private \Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass|\stdClass $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+
+    public function setStdClass()
+    {
+        $this->anotherClass = new \stdClass;
+    }
+}
+
+?>

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/conflict_with_alias4.php.inc

@@ -0,0 +1,50 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias4
+{
+    /**
+     * @var Alias|\stdClass
+     */
+    private $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+
+    public function setStdClass()
+    {
+        $this->anotherClass = new \stdClass;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias4
+{
+    private Alias|\stdClass $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+
+    public function setStdClass()
+    {
+        $this->anotherClass = new \stdClass;
+    }
+}
+
+?>

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/skip_invalid_var_nullable.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class SkipInvalidvarNullable
+{
+    /**
+     * @var ?AnotherClass|\stdClass
+     */
+    private $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+
+    public function setStdClass()
+    {
+        $this->anotherClass = new \stdClass;
+    }
+}
+
+?>

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/use_alias_only.php.inc

@@ -0,0 +1,38 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class UseAliasOnly
+{
+    /**
+     * @var Alias
+     */
+    private $anotherClass;
+
+    public function __construct(Alias $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class UseAliasOnly
+{
+    private Alias $anotherClass;
+
+    public function __construct(Alias $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/use_alias_only2.php.inc

@@ -0,0 +1,48 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class UseAliasOnly2
+{
+    /**
+     * @var Alias|\stdClass
+     */
+    private $anotherClass;
+
+    public function __construct(Alias $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+
+    public function setStdClass()
+    {
+        $this->anotherClass = new \stdClass;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class UseAliasOnly2
+{
+    private Alias|\stdClass $anotherClass;
+
+    public function __construct(Alias $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+
+    public function setStdClass()
+    {
+        $this->anotherClass = new \stdClass;
+    }
+}
+
+?>

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureClassLikeTypeOnly/use_alias_only3.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class UseAliasOnly3
+{
+    private $anotherClass;
+
+    public function __construct(Alias $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureClassLikeTypeOnly;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class UseAliasOnly3
+{
+    private Alias $anotherClass;
+
+    public function __construct(Alias $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>

rules-tests/Php74/Rector/Property/TypedPropertyRector/FixtureImported/conflict_with_alias.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureImported;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias
+{
+    /**
+     * @var Alias
+     */
+    private $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php74\Rector\Property\TypedPropertyRector\FixtureImported;
+
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass;
+use Rector\Tests\Php74\Rector\Property\TypedPropertyRector\Source\AnotherClass as Alias;
+
+final class ConflictWithAlias
+{
+    private Alias $anotherClass;
+
+    public function __construct(AnotherClass $anotherClass)
+    {
+        $this->anotherClass = $anotherClass;
+    }
+}
+
+?>