[TypeDeclaration] Skip array key with null coalescing return mixed on…

… ReturnAnnotationIncorrectNullableRector (#2224)

* Add failing test fixture for ReturnAnnotationIncorrectNullableRector

# Failing Test for ReturnAnnotationIncorrectNullableRector

Based on https://getrector.org/demo/4bef38e5-2250-4e0e-8e50-9646d1d776d2

* Closes #2222

* [TypeDeclaration] Skip array key with null coalescing return mixed on ReturnAnnotationIncorrectNullableRector

* [ci-review] Rector Rectify

* clean up

Co-authored-by: Alies Lapatsin <lptn@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnAnnotationIncorrectNullableRector/Fixture/skip_array_key_with_null_coalescing_return_mixed.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnAnnotationIncorrectNullableRector\Fixture;
+
+final class SkipArraykeyWithNullCoalescingReturnMixed
+{
+    /** @param array<string, string|int|null> $information */
+    public function __construct(private readonly array $information)
+    {
+    }
+
+    /** @return bool|float|int|string|null */
+    public function getValue(string $key): mixed
+    {
+        return $this->information[$key] ?? null;
+    }
+}
+
+?>

rules/TypeDeclaration/Helper/PhpDocNullableTypeHelper.php

@@ -29,6 +29,10 @@ public function resolveUpdatedPhpDocTypeFromPhpDocTypeAndPhpParserType(
         Type $phpDocType,
         Type $phpParserType
     ): ?Type {
+        if ($phpParserType instanceof MixedType) {
+            return null;
+        }
+
         return $this->resolveUpdatedPhpDocTypeFromPhpDocTypeAndPhpParserTypeNullInfo(
             $phpDocType,
             $this->isParserTypeContainingNullType($phpParserType)