[Php81] Skip ReadOnlyPropertyRector on read only class (#3236)

* [Php81] Skip ReadOnlyPropertyRector on read only class

* fixture class

* [ci-review] Rector Rectify

* Final touch: eol

* Final touch: make check readonly class on last resort check to make it faster

Co-authored-by: GitHub Action <action@github.com>

rules-tests/Php81/Rector/Property/ReadOnlyPropertyRector/Fixture/skip_on_read_only_class.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\Property\ReadOnlyPropertyRector\Fixture;
+
+final readonly class SkipOnReadonlyClass
+{
+    public function __construct(
+        private string $name
+    ) {
+    }
+
+    public function getName()
+    {
+        return $this->name;
+    }
+}

rules/Php81/Rector/Property/ReadOnlyPropertyRector.php

@@ -106,6 +106,16 @@ public function provideMinPhpVersion(): int
         return PhpVersionFeature::READONLY_PROPERTY;
     }
 
+    private function shouldSkipInReadonlyClass(Property|Param $node): bool
+    {
+        $class = $this->betterNodeFinder->findParentType($node, Class_::class);
+        if (! $class instanceof Class_) {
+            return true;
+        }
+
+        return $class->isReadonly();
+    }
+
     private function refactorProperty(Property $property): ?Property
     {
         // 1. is property read-only?
@@ -137,6 +147,10 @@ private function refactorProperty(Property $property): ?Property
             return null;
         }
 
+        if ($this->shouldSkipInReadonlyClass($property)) {
+            return null;
+        }
+
         $this->visibilityManipulator->makeReadonly($property);
 
         $attributeGroups = $property->attrGroups;
@@ -174,6 +188,10 @@ private function refactorParam(Param $param): Param | null
             return null;
         }
 
+        if ($this->shouldSkipInReadonlyClass($param)) {
+            return null;
+        }
+
         $this->visibilityManipulator->makeReadonly($param);
         return $param;
     }