Remove regex and fnmatch again on NodeNameResolver (#4968)

* Revert "Fix fixture typo (#4967)"

This reverts commit 76cf20f.

* Revert "[NodeNameResolver] Check regex start delimiter and contains * on NodeNameResolver to use fnmatch() (#4964)"

This reverts commit ef6c8bc.

* fixture

* fixture

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

packages/NodeNameResolver/NodeNameResolver.php

@@ -15,9 +15,7 @@
 use Rector\CodingStyle\Naming\ClassNaming;
 use Rector\Core\Exception\ShouldNotHappenException;
 use Rector\Core\NodeAnalyzer\CallAnalyzer;
-use Rector\Core\Util\StringUtils;
 use Rector\NodeNameResolver\Contract\NodeNameResolverInterface;
-use Rector\NodeNameResolver\Regex\RegexPatternDetector;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 
 final class NodeNameResolver
@@ -33,7 +31,6 @@ final class NodeNameResolver
     public function __construct(
         private readonly ClassNaming $classNaming,
         private readonly CallAnalyzer $callAnalyzer,
-        private readonly RegexPatternDetector $regexPatternDetector,
         private readonly iterable $nodeNameResolvers = []
     ) {
     }
@@ -184,19 +181,7 @@ public function isStringName(string $resolvedName, string $desiredName): bool
             return $desiredName === $resolvedName;
         }
 
-        if (strcasecmp($resolvedName, $desiredName) === 0) {
-            return true;
-        }
-
-        if ($this->regexPatternDetector->isRegexPattern($desiredName)) {
-            return StringUtils::isMatch($resolvedName, $desiredName);
-        }
-
-        if (str_contains($desiredName, '*')) {
-            return fnmatch($desiredName, $resolvedName, FNM_NOESCAPE);
-        }
-
-        return false;
+        return strcasecmp($resolvedName, $desiredName) === 0;
     }
 
     private function isCallOrIdentifier(Expr|Identifier $node): bool

packages/Parallel/Application/ParallelFileProcessor.php

@@ -42,6 +42,7 @@ final class ParallelFileProcessor
      * @var int
      */
     private const SYSTEM_ERROR_LIMIT = 50;
+
     /**
      * The number of chunks a worker can process before getting killed.
      * In contrast the jobSize defines the maximum size of a chunk, a worker process at a time.
@@ -224,6 +225,7 @@ function (array $json) use (
                         ($processSpawner)();
                         return;
                     }
+
                     if ($jobs === []) {
                         $this->processPool->quitProcess($processIdentifier);
                         return;

rules-tests/Php55/Rector/String_/StringClassNameToClassConstantRector/config/configured_rule.php

@@ -7,10 +7,5 @@
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig
-        ->ruleWithConfiguration(StringClassNameToClassConstantRector::class, [
-            'Nette\*',
-            '#^PHPStan\\\\Type#',
-            'Error',
-            'Exception'
-        ]);
+        ->ruleWithConfiguration(StringClassNameToClassConstantRector::class, ['Nette\*', 'Error', 'Exception']);
 };

rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php

@@ -179,6 +179,10 @@ private function shouldSkip(string $classLikeName): bool
             if ($this->nodeNameResolver->isStringName($classLikeName, $classToSkip)) {
                 return true;
             }
+
+            if (fnmatch($classToSkip, $classLikeName, FNM_NOESCAPE)) {
+                return true;
+            }
         }
 
         return false;