[Php71] Skip typed array property on CountOnNullRector (#1049)

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Co-authored-by: Alexander Melihov <amelihovv@ya.ru>
Co-authored-by: GitHub Action <action@github.com>

rules-tests/Php71/Rector/FuncCall/CountOnNullRector/Fixture/skip_typed_array_property.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\Php71\Rector\FuncCall\CountOnNullRector\Fixture;
+
+final class SkipTypedArrayProperty
+{
+    private array $items;
+
+    public function __construct()
+    {
+        $this->items = [];
+    }
+
+    public function count(): int
+    {
+        return count($this->items);
+    }
+}

rules/Php71/NodeAnalyzer/CountableAnalyzer.php

@@ -8,10 +8,15 @@
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Stmt;
+use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\ClassReflection;
+use PHPStan\Reflection\Php\PhpPropertyReflection;
+use PHPStan\Reflection\PropertyReflection;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\TypeWithClassName;
 use PHPStan\Type\UnionType;
 use Rector\NodeNameResolver\NodeNameResolver;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 
 final class CountableAnalyzer
@@ -63,7 +68,30 @@ public function isCastableArrayType(Expr $expr): bool
             return false;
         }
 
+        $phpPropertyReflection = $this->resolveProperty($expr, $classReflection, $propertyName);
+        if (! $phpPropertyReflection instanceof PhpPropertyReflection) {
+            return false;
+        }
+
+        $nativeType = $phpPropertyReflection->getNativeType();
+        if ($nativeType->isIterable()->yes()) {
+            return false;
+        }
+
         $propertyDefaultValue = $propertiesDefaults[$propertyName];
         return $propertyDefaultValue === null;
     }
+
+    private function resolveProperty(
+        PropertyFetch $propertyFetch,
+        ClassReflection $classReflection,
+        string $propertyName
+    ): ?PropertyReflection {
+        $scope = $propertyFetch->getAttribute(AttributeKey::SCOPE);
+        if (! $scope instanceof Scope) {
+            return null;
+        }
+
+        return $classReflection->getProperty($propertyName, $scope);
+    }
 }