[CodingStyle] Skip positive-int and negative-int over int on VarConst…

…antCommentRector (#3709)

* [CodingStyle] Skip positive-int over int on VarConstantCommentRector

* Fixed 🎉

* clean up

* negative-int as well

* add negative-int

* Final touch: add dedicated IntegerRangeType data

* reduce get_class() inside on downgrade code by using string

* Final touch: clean up

* Final touch: clean up

packages/StaticTypeMapper/Mapper/ScalarStringToTypeMapper.php

@@ -12,6 +12,7 @@
 use PHPStan\Type\ClassStringType;
 use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\FloatType;
+use PHPStan\Type\IntegerRangeType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\IterableType;
 use PHPStan\Type\MixedType;
@@ -55,6 +56,14 @@ public function mapScalarStringToType(string $scalarName): Type
             return new ConstantBooleanType(true);
         }
 
+        if ($loweredScalarName === 'positive-int') {
+            return IntegerRangeType::createAllGreaterThan(0);
+        }
+
+        if ($loweredScalarName === 'negative-int') {
+            return IntegerRangeType::createAllSmallerThan(0);
+        }
+
         foreach (self::SCALAR_NAME_BY_TYPE as $objectType => $scalarNames) {
             if (! in_array($loweredScalarName, $scalarNames, true)) {
                 continue;

rules-tests/CodingStyle/Rector/ClassConst/VarConstantCommentRector/Fixture/skip_negative_int_over_int.php.inc

@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\ClassConst\VarConstantCommentRector\Fixture;
+
+final class SkipNegativeIntOverInt
+{
+    /** @var negative-int */
+    public const POSITIVE_INT = -5;
+}

rules-tests/CodingStyle/Rector/ClassConst/VarConstantCommentRector/Fixture/skip_positive_int_over_int.php.inc

@@ -0,0 +1,9 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\ClassConst\VarConstantCommentRector\Fixture;
+
+final class SkipPositiveIntOverInt
+{
+    /** @var positive-int */
+    public const POSITIVE_INT = 5;
+}