[Php81] Apply constructor promotion on NewInInitializerRector (#1288)

Co-authored-by: GitHub Action <action@github.com>

rules-tests/Php81/Rector/ClassMethod/NewInInitializerRector/Fixture/some_class.php.inc

@@ -21,9 +21,7 @@ namespace Rector\Tests\Php81\Rector\ClassMethod\NewInInitializerRector\Fixture;
 
 class SomeClass
 {
-    private Logger $logger;
-
-    public function __construct(Logger $logger = new NullLogger)
+    public function __construct(private Logger $logger = new NullLogger)
     {
     }
 }

rules/Php81/Rector/ClassMethod/NewInInitializerRector.php

@@ -7,7 +7,10 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\BinaryOp\Coalesce;
 use PhpParser\Node\NullableType;
+use PhpParser\Node\Param;
+use PhpParser\Node\Stmt\ClassLike;
 use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\Node\Stmt\Property;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\ValueObject\MethodName;
 use Rector\Core\ValueObject\PhpVersionFeature;
@@ -43,10 +46,8 @@ public function __construct(
                 <<<'CODE_SAMPLE'
 class SomeClass
 {
-    private Logger $logger;
-
     public function __construct(
-        Logger $logger = new NullLogger,
+        private Logger $logger = new NullLogger,
     ) {
     }
 }
@@ -103,6 +104,7 @@ public function refactor(Node $node): ?Node
                 $param->default = $coalesce->right;
 
                 $this->removeNode($toPropertyAssign);
+                $this->processPropertyPromotion($node, $param, $paramName);
             }
         }
 
@@ -113,4 +115,20 @@ public function provideMinPhpVersion(): int
     {
         return PhpVersionFeature::NEW_INITIALIZERS;
     }
+
+    private function processPropertyPromotion(ClassMethod $classMethod, Param $param, string $paramName): void
+    {
+        $classLike = $this->betterNodeFinder->findParentType($classMethod, ClassLike::class);
+        if (! $classLike instanceof ClassLike) {
+            return;
+        }
+
+        $property = $classLike->getProperty($paramName);
+        if (! $property instanceof Property) {
+            return;
+        }
+
+        $param->flags = $property->flags;
+        $this->removeNode($property);
+    }
 }