[TypeDeclaration] Skip ParamTypeDeclarationRector on NullType (#756)

rectorphp · Aug 25, 2021 · f78ffe3 · f78ffe3
1 parent f9ee33b
commit f78ffe3
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/.../TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector/Fixture/skip_null.php.inc b/.../TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector/Fixture/skip_null.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\FunctionLike\ParamTypeDeclarationRector\Fixture;
+
+class SkipNull
+{
+    /**
+     * @param null $value
+     */
+    public function someFunction($value)
+    {
+    }
+}
diff --git a/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php b/rules/TypeDeclaration/Rector/FunctionLike/ParamTypeDeclarationRector.php
@@ -10,6 +10,7 @@
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\Interface_;
 use PHPStan\Type\MixedType;
+use PHPStan\Type\NullType;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\DeadCode\PhpDoc\TagRemover\ParamTagRemover;
@@ -147,6 +148,10 @@ private function refactorParam(Param $param, ClassMethod | Function_ $functionLi
             return;
         }
 
+        if ($inferedType instanceof NullType) {
+            return;
+        }
+
         if ($this->traitTypeAnalyzer->isTraitType($inferedType)) {
             return;
         }