[Downgrade PHP 8.1] Add DowngradeNewInInitializerRector (#1275)

config/set/downgrade-php81.php

@@ -7,6 +7,7 @@
 use Rector\DowngradePhp81\Rector\ClassConst\DowngradeFinalizePublicClassConstantRector;
 use Rector\DowngradePhp81\Rector\FuncCall\DowngradeFirstClassCallableSyntaxRector;
 use Rector\DowngradePhp81\Rector\FunctionLike\DowngradeNeverTypeDeclarationRector;
+use Rector\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector;
 use Rector\DowngradePhp81\Rector\Instanceof_\DowngradePhp81ResourceReturnToObjectRector;
 use Rector\DowngradePhp81\Rector\Property\DowngradeReadonlyPropertyRector;
 use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
@@ -19,6 +20,7 @@
     $services->set(DowngradeFinalizePublicClassConstantRector::class);
     $services->set(DowngradeFirstClassCallableSyntaxRector::class);
     $services->set(DowngradeNeverTypeDeclarationRector::class);
+    $services->set(DowngradeNewInInitializerRector::class);
     $services->set(DowngradePhp81ResourceReturnToObjectRector::class);
     $services->set(DowngradeReadonlyPropertyRector::class);
 };

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/DowngradeNewInInitializerRectorTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class DowngradeNewInInitializerRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    /**
+     * @return Iterator<SmartFileInfo>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/arrow_function.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+$func = fn (stdClass $obj = new stdClass) => $obj;
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+$func = function (stdClass $obj = null) {
+    $obj ??= new stdClass;
+    return $obj;
+};
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/closure.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+$func = function(stdClass $obj = new stdClass, $arg = null) {
+    var_dump($arg);
+};
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+$func = function(stdClass $obj = null, $arg = null) {
+    $obj ??= new stdClass;
+    var_dump($arg);
+};
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/func_call.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+function someFunc($arg, stdClass $obj = new stdClass)
+{
+    var_dump($arg);
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+function someFunc($arg, stdClass $obj = null)
+{
+    $obj ??= new stdClass;
+    var_dump($arg);
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/method_call.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function foo(stdClass $obj = new stdClass)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function foo(stdClass $obj = null)
+    {
+        $obj ??= new stdClass;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_in_initializer.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public stdClass $obj = new stdClass)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public ?stdClass $obj = null)
+    {
+        $this->obj = $obj ?? new stdClass;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_in_initializer_multi_args.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public stdClass $o1 = new stdClass, public stdClass $o2 = new stdClass)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public ?stdClass $o1 = null, public ?stdClass $o2 = null)
+    {
+        $this->o1 = $o1 ?? new stdClass;
+        $this->o2 = $o2 ?? new stdClass;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_in_initializer_nullable.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public ?stdClass $obj = new stdClass)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public ?stdClass $obj = null)
+    {
+        $this->obj = $obj ?? new stdClass;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_in_initializer_nullable_union_type.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public Foo|stdClass|null $obj = new stdClass)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public Foo|stdClass|null $obj = null)
+    {
+        $this->obj = $obj ?? new stdClass;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_in_initializer_union_type.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public Foo|stdClass $obj = new stdClass)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public Foo|stdClass|null $obj = null)
+    {
+        $this->obj = $obj ?? new stdClass;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_in_initializer_with_stmts.php.inc

@@ -0,0 +1,28 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public stdClass $obj = new stdClass)
+    {
+        $obj->foo = 'bar';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public function __construct(public ?stdClass $obj = null)
+    {
+        $this->obj = $obj ?? new stdClass;
+        $obj->foo = 'bar';
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_not_promoted.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public stdClass $obj;
+
+    public function __construct(stdClass $obj = new stdClass)
+    {
+        $this->obj = $obj;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public stdClass $obj;
+
+    public function __construct(stdClass $obj = null)
+    {
+        $obj ??= new stdClass;
+        $this->obj = $obj;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/static_call.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public static function foo(stdClass $obj = new stdClass)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+class SomeClass
+{
+    public static function foo(stdClass $obj = null)
+    {
+        $obj ??= new stdClass;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/config/configured_rule.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector;
+
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+    $services->set(DowngradeNewInInitializerRector::class);
+};