[Php80] Skip ObjectType on ChangeSwitchToMatchRector (#5719)

* [Php80] Skip ObjectType on ChangeSwitchToMatchRector * [Php80] Skip ObjectType on ChangeSwitchToMatchRector
rectorphp · Mar 14, 2024 · fbba860 · fbba860
1 parent d01d16e
commit fbba860
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/rules-tests/Php80/Rector/Switch_/ChangeSwitchToMatchRector/Fixture/skip_object_type.php.inc b/rules-tests/Php80/Rector/Switch_/ChangeSwitchToMatchRector/Fixture/skip_object_type.php.inc
@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Switch_\ChangeSwitchToMatchRector\Fixture;
+
+use Rector\Tests\Php80\Rector\Switch_\ChangeSwitchToMatchRector\Source\SomeResponse;
+
+class SkipObjectType {
+    public function doTheAction(SomeResponse $example): string
+    {
+        switch ($example) {
+            case $example::build('a', 'b'):
+                return 'here';
+                break;
+            default:
+                return 'there';
+        }
+    }
+}
diff --git a/rules-tests/Php80/Rector/Switch_/ChangeSwitchToMatchRector/Source/SomeResponse.php b/rules-tests/Php80/Rector/Switch_/ChangeSwitchToMatchRector/Source/SomeResponse.php
@@ -9,4 +9,9 @@ final class SomeResponse
     public function __construct($content, $statusCode)
     {
     }
+
+    public static function build($a, $b): self
+    {
+        return new self($a, $b);
+    }
 }
diff --git a/rules/Php80/Rector/Switch_/ChangeSwitchToMatchRector.php b/rules/Php80/Rector/Switch_/ChangeSwitchToMatchRector.php
@@ -10,6 +10,7 @@
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\Node\Stmt\Switch_;
+use PHPStan\Type\ObjectType;
 use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
 use Rector\Php80\NodeAnalyzer\MatchSwitchAnalyzer;
 use Rector\Php80\NodeFactory\MatchFactory;
@@ -102,6 +103,10 @@ public function refactor(Node $node): ?Node
 
             $isReturn = $this->matchSwitchAnalyzer->isReturnCondsAndExprs($condAndExprs);
 
+            if ($this->nodeTypeResolver->getType($stmt->cond) instanceof ObjectType) {
+                continue;
+            }
+
             $matchResult = $this->matchFactory->createFromCondAndExprs($stmt->cond, $condAndExprs, $nextStmt);
             if (! $matchResult instanceof MatchResult) {
                 continue;