[Config] Use RectorConfig::configure() on tests (#5593)

* [Config] Use RectorConfig::configure() on tests

* fix new line per call

* revert fixture

tests/Issues/AlwaysTrueIfInDeadConstructor/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector;
 use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([RemoveAlwaysTrueIfConditionRector::class, RemoveEmptyClassMethodRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveAlwaysTrueIfConditionRector::class, RemoveEmptyClassMethodRector::class]);

tests/Issues/ChangeSwitchTernary/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\Php80\Rector\Switch_\ChangeSwitchToMatchRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([ChangeSwitchToMatchRector::class, TernaryFalseExpressionToIfRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([ChangeSwitchToMatchRector::class, TernaryFalseExpressionToIfRector::class]);

tests/Issues/ClassOnObjectGetDebugType/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\Php80\Rector\FuncCall\ClassOnObjectRector;
 use Rector\Php80\Rector\Ternary\GetDebugTypeRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([ClassOnObjectRector::class, GetDebugTypeRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([ClassOnObjectRector::class, GetDebugTypeRector::class]);

tests/Issues/ContinueToBreakSwitch/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\Php52\Rector\Switch_\ContinueToBreakInSwitchRector;
 use Rector\Php70\Rector\Break_\BreakNotInLoopOrSwitchToReturnRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([BreakNotInLoopOrSwitchToReturnRector::class, ContinueToBreakInSwitchRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([BreakNotInLoopOrSwitchToReturnRector::class, ContinueToBreakInSwitchRector::class]);

tests/Issues/DeadInstanceFlip/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\If_\RemoveDeadInstanceOfRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([RemoveDeadInstanceOfRector::class, FlipTypeControlToUseExclusiveTypeRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveDeadInstanceOfRector::class, FlipTypeControlToUseExclusiveTypeRector::class]);

tests/Issues/EmptyBooleanCompare/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
 use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([BooleanInIfConditionRuleFixerRector::class, DisallowedEmptyRuleFixerRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([BooleanInIfConditionRuleFixerRector::class, DisallowedEmptyRuleFixerRector::class]);

tests/Issues/EmptyLongArraySyntax/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\Php73\Rector\ConstFetch\SensitiveConstantNameRector;
 use Rector\Php80\Rector\ClassMethod\AddParamBasedOnParentClassMethodRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([SensitiveConstantNameRector::class, AddParamBasedOnParentClassMethodRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([SensitiveConstantNameRector::class, AddParamBasedOnParentClassMethodRector::class]);

tests/Issues/GetCalledClassToSelfAndStatic/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\Php55\Rector\FuncCall\GetCalledClassToSelfClassRector;
 use Rector\Php55\Rector\FuncCall\GetCalledClassToStaticClassRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(GetCalledClassToSelfClassRector::class);
-    $rectorConfig->rule(GetCalledClassToStaticClassRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([GetCalledClassToSelfClassRector::class, GetCalledClassToStaticClassRector::class]);

tests/Issues/IfElseAssignReturnUsed/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(ChangeIfElseValueAssignToEarlyReturnRector::class);
-    $rectorConfig->rule(SimplifyIfElseToTernaryRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([ChangeIfElseValueAssignToEarlyReturnRector::class, SimplifyIfElseToTernaryRector::class]);

tests/Issues/IndentationCrash/config/code_quality_coding_style_configured_rule.php

@@ -7,10 +7,11 @@
 use Rector\Config\RectorConfig;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        SimplifyIfReturnBoolRector::class,
-        NewlineAfterStatementRector::class,
-        StringClassNameToClassConstantRector::class,
-    ]);
-};
+return RectorConfig::configure()
+    ->withRules(
+        [
+            SimplifyIfReturnBoolRector::class,
+            NewlineAfterStatementRector::class,
+            StringClassNameToClassConstantRector::class,
+        ]
+    );

tests/Issues/InfiniteLoop/config/infinite_loop.php

@@ -6,7 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\Tests\Issues\InfiniteLoop\Rector\MethodCall\InfinityLoopRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(InfinityLoopRector::class);
-    $rectorConfig->rule(SimplifyDeMorganBinaryRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([InfinityLoopRector::class, SimplifyDeMorganBinaryRector::class]);

tests/Issues/InfiniteSwapParams/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\Php80\Rector\Catch_\RemoveUnusedVariableInCatchRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([RemoveUnusedVariableInCatchRector::class, OptionalParametersAfterRequiredRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveUnusedVariableInCatchRector::class, OptionalParametersAfterRequiredRector::class]);

tests/Issues/InlineTypedFromConstructorDefaultValue/config/configured_rule.php

@@ -6,9 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        TypedPropertyFromStrictConstructorRector::class,
-        InlineConstructorDefaultToPropertyRector::class,
-    ]);
-};
+return RectorConfig::configure()
+    ->withRules([TypedPropertyFromStrictConstructorRector::class, InlineConstructorDefaultToPropertyRector::class]);

tests/Issues/Issue6480/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\If_\RemoveDeadInstanceOfRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(RemoveDeadInstanceOfRector::class);
-    $rectorConfig->rule(SwitchNegatedTernaryRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveDeadInstanceOfRector::class, SwitchNegatedTernaryRector::class]);

tests/Issues/Issue6481/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\If_\RemoveDeadInstanceOfRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(EncapsedStringsToSprintfRector::class);
-    $rectorConfig->rule(RemoveDeadInstanceOfRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([EncapsedStringsToSprintfRector::class, RemoveDeadInstanceOfRector::class]);

tests/Issues/Issue6561/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
 use Rector\Config\RectorConfig;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(ExplicitBoolCompareRector::class);
-    $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([ExplicitBoolCompareRector::class, CountArrayToEmptyArrayComparisonRector::class]);

tests/Issues/Issue6670/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
 use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(RemoveUnusedPrivateMethodRector::class);
-    $rectorConfig->rule(RemoveAlwaysElseRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveUnusedPrivateMethodRector::class, RemoveAlwaysElseRector::class]);

tests/Issues/Issue6840/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(ClassPropertyAssignToConstructorPromotionRector::class);
-    $rectorConfig->rule(NewlineAfterStatementRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([ClassPropertyAssignToConstructorPromotionRector::class, NewlineAfterStatementRector::class]);

tests/Issues/Issue7112/config/configured_rule.php

@@ -6,7 +6,7 @@
 use Rector\Naming\Rector\Assign\RenameVariableToMatchMethodCallReturnTypeRector;
 use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(RenameVariableToMatchMethodCallReturnTypeRector::class);
-    $rectorConfig->rule(AddVoidReturnTypeWhereNoReturnRector::class);
-};
+return RectorConfig::configure()
+    ->withRules(
+        [RenameVariableToMatchMethodCallReturnTypeRector::class, AddVoidReturnTypeWhereNoReturnRector::class]
+    );

tests/Issues/Issue7306/config/configured_rule.php

@@ -7,10 +7,7 @@
 use Rector\CodingStyle\Rector\Stmt\NewlineAfterStatementRector;
 use Rector\Config\RectorConfig;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        SimplifyIfNotNullReturnRector::class,
-        ExplicitBoolCompareRector::class,
-        NewlineAfterStatementRector::class,
-    ]);
-};
+return RectorConfig::configure()
+    ->withRules(
+        [SimplifyIfNotNullReturnRector::class, ExplicitBoolCompareRector::class, NewlineAfterStatementRector::class]
+    );

tests/Issues/Issue7374/config/configured_rule.php

@@ -6,9 +6,5 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector;
 use Rector\Naming\Rector\ClassMethod\RenameVariableToMatchNewTypeRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        RemoveUnusedPrivateMethodParameterRector::class,
-        RenameVariableToMatchNewTypeRector::class,
-    ]);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveUnusedPrivateMethodParameterRector::class, RenameVariableToMatchNewTypeRector::class]);

tests/Issues/IssueAndIfCompleteDeMorgan/config/configured_rule.php

@@ -7,10 +7,11 @@
 use Rector\Config\RectorConfig;
 use Rector\EarlyReturn\Rector\If_\ChangeAndIfToEarlyReturnRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        ChangeAndIfToEarlyReturnRector::class,
-        CompleteDynamicPropertiesRector::class,
-        SimplifyDeMorganBinaryRector::class,
-    ]);
-};
+return RectorConfig::configure()
+    ->withRules(
+        [
+            ChangeAndIfToEarlyReturnRector::class,
+            CompleteDynamicPropertiesRector::class,
+            SimplifyDeMorganBinaryRector::class,
+        ]
+    );

tests/Issues/IssueAnnotation/config/configured_rule.php

@@ -5,6 +5,5 @@
 use Rector\Config\RectorConfig;
 use Rector\DowngradePhp80\Rector\MethodCall\DowngradeNamedArgumentRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(DowngradeNamedArgumentRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([DowngradeNamedArgumentRector::class]);

tests/Issues/IssueConditionalType/config/configured_rule.php

@@ -5,6 +5,5 @@
 use Rector\Config\RectorConfig;
 use Rector\DowngradePhp80\Rector\FunctionLike\DowngradeMixedTypeDeclarationRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(DowngradeMixedTypeDeclarationRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([DowngradeMixedTypeDeclarationRector::class]);

tests/Issues/IssueConstructorPromotionRename/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\Naming\Rector\Class_\RenamePropertyToMatchTypeRector;
 use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(ClassPropertyAssignToConstructorPromotionRector::class);
-    $rectorConfig->rule(RenamePropertyToMatchTypeRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([ClassPropertyAssignToConstructorPromotionRector::class, RenamePropertyToMatchTypeRector::class]);

tests/Issues/IssueCreatePublicPropertyOnRename/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\Config\RectorConfig;
 use Rector\Naming\Rector\Class_\RenamePropertyToMatchTypeRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(RenamePropertyToMatchTypeRector::class);
-    $rectorConfig->rule(CompleteDynamicPropertiesRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([RenamePropertyToMatchTypeRector::class, CompleteDynamicPropertiesRector::class]);

tests/Issues/IssueRemoveAlwaysElseReturnEarlyIfVariable/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
 use Rector\EarlyReturn\Rector\StmtsAwareInterface\ReturnEarlyIfVariableRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([RemoveAlwaysElseRector::class, ReturnEarlyIfVariableRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveAlwaysElseRector::class, ReturnEarlyIfVariableRector::class]);

tests/Issues/IssueReturnBeforeElseIf/config/configured_rule_and.php

@@ -6,7 +6,5 @@
 use Rector\EarlyReturn\Rector\If_\ChangeAndIfToEarlyReturnRector;
 use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(ChangeAndIfToEarlyReturnRector::class);
-    $rectorConfig->rule(RemoveAlwaysElseRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([ChangeAndIfToEarlyReturnRector::class, RemoveAlwaysElseRector::class]);

tests/Issues/JsonThrowWithChangeAndIf/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\EarlyReturn\Rector\If_\ChangeAndIfToEarlyReturnRector;
 use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(JsonThrowOnErrorRector::class);
-    $rectorConfig->rule(ChangeAndIfToEarlyReturnRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([JsonThrowOnErrorRector::class, ChangeAndIfToEarlyReturnRector::class]);

tests/Issues/LocallyThis/config/configured_rule.php

@@ -6,9 +6,7 @@
 use Rector\Config\RectorConfig;
 use Rector\Php70\Rector\MethodCall\ThisCallOnStaticMethodToStaticCallRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        LocallyCalledStaticMethodToNonStaticRector::class,
-        ThisCallOnStaticMethodToStaticCallRector::class,
-    ]);
-};
+return RectorConfig::configure()
+    ->withRules(
+        [LocallyCalledStaticMethodToNonStaticRector::class, ThisCallOnStaticMethodToStaticCallRector::class]
+    );

tests/Issues/PartialValueDocblockUpdate/config/configured_rule.php

@@ -5,6 +5,5 @@
 use Rector\Config\RectorConfig;
 use Rector\Tests\Issues\PartialValueDocblockUpdate\Source\PartialUpdateTestRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(PartialUpdateTestRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([PartialUpdateTestRector::class]);

tests/Issues/RemoveUnusedParamInMiddle/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector;
 use Rector\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(RemoveUnusedConstructorParamRector::class);
-    $rectorConfig->rule(RemoveUnusedPrivatePropertyRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveUnusedConstructorParamRector::class, RemoveUnusedPrivatePropertyRector::class]);

tests/Issues/RemoveUnusedVariableAlwaysElse/config/configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\DeadCode\Rector\Assign\RemoveUnusedVariableAssignRector;
 use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(RemoveUnusedVariableAssignRector::class);
-    $rectorConfig->rule(RemoveAlwaysElseRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveUnusedVariableAssignRector::class, RemoveAlwaysElseRector::class]);

tests/Issues/RemoveUnusedVariableDouble/config/configured_rule.php

@@ -6,6 +6,5 @@
 use Rector\DeadCode\Rector\Assign\RemoveDoubleAssignRector;
 use Rector\DeadCode\Rector\Assign\RemoveUnusedVariableAssignRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([RemoveDoubleAssignRector::class, RemoveUnusedVariableAssignRector::class]);
-};
+return RectorConfig::configure()
+    ->withRules([RemoveDoubleAssignRector::class, RemoveUnusedVariableAssignRector::class]);

tests/Issues/ReplaceStmtToExpr/config/configured_rule.php

@@ -7,10 +7,11 @@
 use Rector\Config\RectorConfig;
 use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rules([
-        ExplicitBoolCompareRector::class,
-        FlipTypeControlToUseExclusiveTypeRector::class,
-        ReturnBinaryOrToEarlyReturnRector::class,
-    ]);
-};
+return RectorConfig::configure()
+    ->withRules(
+        [
+            ExplicitBoolCompareRector::class,
+            FlipTypeControlToUseExclusiveTypeRector::class,
+            ReturnBinaryOrToEarlyReturnRector::class,
+        ]
+    );

tests/Issues/ReturnEmptyNodes/config/configured_rule.php

@@ -5,6 +5,5 @@
 use Rector\Config\RectorConfig;
 use Rector\Tests\Issues\ReturnEmptyNodes\Source\ReturnEmptyStmtsRector;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(ReturnEmptyStmtsRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([ReturnEmptyStmtsRector::class]);

tests/Issues/ScopeNotAvailable/config/callable_this_configured_rule.php

@@ -6,7 +6,5 @@
 use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
 use Rector\Config\RectorConfig;
 
-return static function (RectorConfig $rectorConfig): void {
-    $rectorConfig->rule(CallableThisArrayToAnonymousFunctionRector::class);
-    $rectorConfig->rule(CountArrayToEmptyArrayComparisonRector::class);
-};
+return RectorConfig::configure()
+    ->withRules([CallableThisArrayToAnonymousFunctionRector::class, CountArrayToEmptyArrayComparisonRector::class]);