Do not remove final modifier from private constructors (#1663)

rectorphp · Jan 12, 2022 · fd34e6c · fd34e6c
1 parent bbe0567
commit fd34e6c
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/...assMethod/FinalPrivateToPrivateVisibilityRector/Fixture/final_private_constructor.php.inc b/...assMethod/FinalPrivateToPrivateVisibilityRector/Fixture/final_private_constructor.php.inc
@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\ClassMethod\FinalPrivateToPrivateVisibilityRector\Fixture;
+
+abstract class FinalPrivate
+{
+    final private function __construct()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\ClassMethod\FinalPrivateToPrivateVisibilityRector\Fixture;
+
+abstract class FinalPrivate
+{
+    final private function __construct()
+    {
+    }
+}
+
+?>
diff --git a/rules/Php80/Rector/ClassMethod/FinalPrivateToPrivateVisibilityRector.php b/rules/Php80/Rector/ClassMethod/FinalPrivateToPrivateVisibilityRector.php
@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Stmt\ClassMethod;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\ValueObject\MethodName;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -81,6 +82,10 @@ private function shouldSkip(ClassMethod $classMethod): bool
             return true;
         }
 
+        if ($classMethod->name->toString() === MethodName::CONSTRUCT) {
+            return true;
+        }
+
         return ! $classMethod->isPrivate();
     }
 }