[NodeDecorator] Improve MixPhpHtmlDecorator::decorateNextNodesInlineH…

…TML() performance: stop loop on found InlineHTML (#3305)

* [NodeDecorator] Improve MixPhpHtmlDecorator performance: stop on found InlineHTML

* update fixture

* stop on isset old token exists

src/NodeDecorator/MixPhpHtmlDecorator.php

@@ -40,7 +40,7 @@ public function decorateNextNodesInlineHTML(File $file, array $nodes): void
 
             $endTokenPost = $subNode->getEndTokenPos();
             if (isset($oldTokens[$endTokenPost])) {
-                continue;
+                return;
             }
 
             if (! isset($nodes[$key + 1])) {
@@ -51,6 +51,7 @@ public function decorateNextNodesInlineHTML(File $file, array $nodes): void
             if ($nodes[$key + 1] instanceof InlineHTML) {
                 // No token end? Just added
                 $nodes[$key + 1]->setAttribute(AttributeKey::ORIGINAL_NODE, null);
+                break;
             }
         }
     }

tests/Issues/InsertFirstBeforeInlineHTML/Fixture/fixture.php.inc

@@ -2,6 +2,7 @@
 -----
 <?php
 
+echo 'this is new stmt before InlineHTML';
 echo 'this is new stmt before InlineHTML';
 ?>
 <div><?php 

tests/Issues/InsertFirstBeforeInlineHTML/Source/InsertBeforeInlineHTMLRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Scalar\String_;
 use PhpParser\Node\Stmt\Echo_;
+use PhpParser\Node\Stmt\InlineHTML;
 use Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespace;
 use Rector\Core\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -36,7 +37,7 @@ public function refactor(Node $node)
         $echo = new Echo_([new String_('this is new stmt before InlineHTML')]);
 
         $node->stmts = array_merge(
-            [$echo],
+            [$echo, $echo],
             $node->stmts
         );
 

tests/Issues/ReturnArrayNodeBeforeInlineHTMLStmt/FixtureArrayBeforeInlineHTML/fixture.php.inc

@@ -2,6 +2,7 @@
 -----
 <?php
 
+echo 'this is new stmt before InlineHTML';
 echo 'this is new stmt before InlineHTML';
 ?>
 <div><?php 

tests/Issues/ReturnArrayNodeBeforeInlineHTMLStmt/FixtureArrayBeforeInlineHTML/next_line_php_in_inline_html.php.inc

@@ -6,6 +6,7 @@ echo $this->filter ;
 -----
 <?php
 
+echo 'this is new stmt before InlineHTML';
 echo 'this is new stmt before InlineHTML';
 ?>
 <div><?php 

tests/Issues/ReturnArrayNodeBeforeInlineHTMLStmt/Source/ArrayAddBeforeInlineHTMLRector.php

@@ -54,6 +54,7 @@ public function refactor(Node $node)
         $this->justAdded[$this->file->getFilePath()] = true;
 
         return [
+            $echo,
             $echo,
             $node,
         ];