[Privatization] Fix crash on assign inside Arg on ChangeReadOnlyVaria…

…bleWithDefaultValueToConstantRector (#3423)

* [Privatization] Skip crash on assign inside Arg on ChangeReadOnlyVariableWithDefaultValueToConstantRector

* Fixed 🎉

* use Expression to cover other use case

rules-tests/Privatization/Rector/Class_/ChangeReadOnlyVariableWithDefaultValueToConstantRector/Fixture/skip_assign_inside_arg.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\Class_\ChangeReadOnlyVariableWithDefaultValueToConstantRector\Fixture;
+
+final class SkipAssignInsideArg
+{
+    public function run()
+    {
+        $c = base64_decode(str_replace(['--', '_'], ['+', '/'], $key));
+
+        $ivlen = openssl_cipher_iv_length($cipher = "AES-128-CFB");
+        $hmac = substr($c, $ivlen, $sha2len = 32);
+        $ciphertext_raw = substr($c, $ivlen + $sha2len);
+    }
+}

rules/Privatization/Rector/Class_/ChangeReadOnlyVariableWithDefaultValueToConstantRector.php

@@ -15,10 +15,12 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassConst;
 use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\Node\Stmt\Expression;
 use Rector\BetterPhpDocParser\PhpDocManipulator\VarAnnotationManipulator;
 use Rector\Core\Exception\ShouldNotHappenException;
 use Rector\Core\NodeManipulator\ClassMethodAssignManipulator;
 use Rector\Core\Rector\AbstractRector;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PostRector\Collector\PropertyToAddCollector;
 use Rector\Privatization\Naming\ConstantNaming;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -203,6 +205,11 @@ private function refactorClassMethod(ClassMethod $classMethod, Class_ $class, ar
                 }
             }
 
+            $parentAssign = $readOnlyVariableAssign->getAttribute(AttributeKey::PARENT_NODE);
+            if (! $parentAssign instanceof Expression) {
+                continue;
+            }
+
             $this->removeNode($readOnlyVariableAssign);
             $classConst = $this->createPrivateClassConst($variable, $readOnlyVariableAssign->expr);