Add constant FilesystemIterator::SKIP_DOTS when flags parameter is used

[jawira]

I created a new rector rule to update \FilesystemIterator , this rule is supposed to be used when migrating code from php 8.1 to 8.2.

Before PHP 8.2, \FilesystemIterator::SKIP_DOTS was always set and couldn't be removed, this has been fixed in PHP 8.2 and now you have to add this constant manually if you want to maintain the same behavior. This is also explained in documentation https://www.php.net/manual/en/filesystemiterator.construct.php.

You can see an example here https://3v4l.org/HrmZ2.

Note that this rule is important only if you use the second parameter ($params) from FilesystemIterator, the reason is that \FilesystemIterator::SKIP_DOTS is part of $params default value.

// Nothing to do since \FilesystemIterator::SKIP_DOTS is part of default value.  
new \FilesystemIterator(__DIR__);

// Must add \FilesystemIterator::SKIP_DOTS to maintain same behavior before PHP 8.2
new \FilesystemIterator(__DIR__, \FilesystemIterator::KEY_AS_FILENAME);

I don't have experience creating Rector rules, so I'm open to any comment/suggestion :)

[samsonasik]

Looks good 👍

[TomasVotruba]

Thank you 👏

[samsonasik]

Downgrade build failure seems unrelated:

------------------------------------------------------------
Parse error: rector-prefixed-downgraded/vendor/nette/utils/src/Utils/Arrays.php:171
    169|      */
    170|     public static function grep(array $array, #[\JetBrains\PhpStorm\Language('RegExp')] string $pattern, int $flags = 0) : array
  > 171|     {
    172|         return Strings::pcre('preg_grep', [$pattern, $array, $flags]);
    173|     }
Unexpected '{', expecting variable (T_VARIABLE) in rector-prefixed-downgraded/vendor/nette/utils/src/Utils/Arrays.php on line 171
------------------------------------------------------------
Parse error: rector-prefixed-downgraded/vendor/nette/utils/src/Utils/Strings.php:399
    397|      */
    398|     public static function split(string $subject, #[\JetBrains\PhpStorm\Language('RegExp')] string $pattern, int $flags = 0) : array
  > 399|     {
    400|         return self::pcre('preg_split', [$pattern, $subject, -1, $flags | \PREG_SPLIT_DELIM_CAPTURE]);
    401|     }
Unexpected '{', expecting variable (T_VARIABLE) in rector-prefixed-downgraded/vendor/nette/utils/src/Utils/Strings.php on line 399

seems due to new nette/utils release https://github.com/nette/utils/releases/tag/v3.2.9

[samsonasik]

The error seems on downgrading to php 7.4 on Attribute in parameter, ref https://3v4l.org/F7j9M#v7.4.33, which may solvable to re-print the parameter to make new line instead of single line https://3v4l.org/o82Pl#v7.4.2

[samsonasik]

Actually, there is already DowngradeAttributeToAnnotationRector, since it prefixed vendor that we will not use in directly outside rector, I think we can add more register to config/set/downgrade-php80.php in rector-downgrade-php

[samsonasik]

@TomasVotruba I created PR rectorphp/rector-downgrade-php#36 for it.

[samsonasik]

@TomasVotruba I created another PR alternative specific rule to reprint the node when attribute line is equal with node line at PR rectorphp/rector-downgrade-php#37