Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPStan] Fix PHPStan notice on ParallelFileProcessor #2011

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

samsonasik
Copy link
Member

Tried locally, PHPStan got notice:

composer phpstan         
> php -dmemory_limit=1G vendor/bin/phpstan analyse --ansi --error-format symplify
Note: Using configuration file /Users/samsonasik/www/rector-src/phpstan.neon.
 1512/1512 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  packages/Parallel/Application/ParallelFileProcessor.php:59
 ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  - '#Instead of array shape, use value object with specific types in constructor and getters#'
 ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


                                                                                                                        
 [ERROR] Found 1 errors           

This PR ignored it in phpstan.neon

@samsonasik samsonasik enabled auto-merge (squash) April 5, 2022 09:40
@samsonasik samsonasik merged commit 08a3243 into main Apr 5, 2022
@samsonasik samsonasik deleted the fix-phpstan-notice branch April 5, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant