Fixes descending order on IfToSpaceship

[peterlupu]

Should fix #7118.

Please code review this, as I think I found errors in the existing unit tests.

Also, I had to jump through some hoops in order to please phpstan's cognitive complexity calculator.

[samsonasik]

could you rebase and amend commit with remove 'quote' in commit message? - it may make build stopped when merged

[peterlupu]

could you rebase and amend commit with remove 'quote' in commit message? - it may make build stopped when merged

hi

sorry if this is offtopic but can't seem to be able to do this. a little help, please?

$ git checkout b3dda553a1f21c9b14c15b79a90b0fbb503eb3f1
$ git commit -m 'merge branch' --amend
$ git checkout -
$ git rebase ced947f001
$ git push

[samsonasik]

You should can do:

#ensure base branch is PR branch
git checkout test/IfToSpaceshipRector-asc-desc 

# create a branch for backup
git checkout -b temp 

# back to branch PR
git checkout test/IfToSpaceshipRector-asc-desc 

git reset --hard HEAD~10 

git remote add upstream https://github.com/rectorphp/rector-src 

git pull upstream main
git cherry-pick 59bde137c23dbba32eaeb7df8d94e570aeff6996 

git push --force origin test/IfToSpaceshipRector-asc-desc

[peterlupu]

You should can do:

#ensure base branch is PR branch
git checkout test/IfToSpaceshipRector-asc-desc 

# create a branch for backup
git checkout -b temp 

# back to branch PR
git checkout test/IfToSpaceshipRector-asc-desc 

git reset --hard HEAD~10 

git remote add upstream https://github.com/rectorphp/rector-src 

git pull upstream main
git cherry-pick 59bde137c23dbba32eaeb7df8d94e570aeff6996 

git push --force origin test/IfToSpaceshipRector-asc-desc

I think I managed to remove the quotes, thanks to you. 🎉

[samsonasik]

Thank you @peterlupu