Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove RectifiedNode value object for RectifiedAnalyzer #3079

Merged
merged 29 commits into from Nov 20, 2022
Merged

[Core] Remove RectifiedNode value object for RectifiedAnalyzer #3079

merged 29 commits into from Nov 20, 2022

Commits on Nov 19, 2022

  1. [Core] Remove RectifiedNode value object for RectifiedAnalyzer

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    4585d07 View commit details
    Browse the repository at this point in the history

  2. clean up

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    3cc4355 View commit details
    Browse the repository at this point in the history

  3. Final touch: apply @var class-string<RectorInterface>[] and @param cl… 

    …ass-string<RectorInterface> for created by rule attribute
    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    69965cb View commit details
    Browse the repository at this point in the history

  4. Really Final touch: handle consecutive return null; with phpstan cach… 

    …e printer exists
    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    e70f424 View commit details
    Browse the repository at this point in the history

  5. Really Really Final touch: early create by rule, no need to loop when… 

    … $node === $originalNode
    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    bf0d2bf View commit details
    Browse the repository at this point in the history

  6. Really Really Final touch: clean up: re-use if

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    642ceb3 View commit details
    Browse the repository at this point in the history

  7. Really Final touch: different if to easiser to read

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    807c59e View commit details
    Browse the repository at this point in the history

  8. Final touch: better method name

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    39ec81c View commit details
    Browse the repository at this point in the history

  9. Final touch: Move comment to method, more description for future note

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    c1a982f View commit details
    Browse the repository at this point in the history

  10. Really final touch: clarify comment

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    0d7943e View commit details
    Browse the repository at this point in the history

  11. Really Really Really final touch: verify comment

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    a4b68e6 View commit details
    Browse the repository at this point in the history

  12. Really Final touch: remove unnecessary array_key_first and array_key_… 

    …last
    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    26583dd View commit details
    Browse the repository at this point in the history

  13. Final touch: phpstan_cache_printer attribute is always on Expr Node

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    c0805fd View commit details
    Browse the repository at this point in the history

  14. Final touch: Fix range line can be -1 on if Next Node moved up

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    8b53051 View commit details
    Browse the repository at this point in the history

  15. Final touch: comment

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    ae7620d View commit details
    Browse the repository at this point in the history

  16. Final touch: comment

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    54b6ca3 View commit details
    Browse the repository at this point in the history

  17. [ci-review] Rector Rectify

    @actions-user
    actions-user committed Nov 19, 2022
    Copy the full SHA
    c033531 View commit details
    Browse the repository at this point in the history

  18. Final touch: clean up

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    d1fa73b View commit details
    Browse the repository at this point in the history

  19. Final touch: clean up

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    6888291 View commit details
    Browse the repository at this point in the history

  20. only verify against Expr

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    099c914 View commit details
    Browse the repository at this point in the history

  21. final touch: decorate the Node as well

    @samsonasik
    samsonasik committed Nov 19, 2022
    Copy the full SHA
    db11b04 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. Finally: Real solution, immediate connect existing Node after refactor

    @samsonasik
    samsonasik committed Nov 20, 2022
    Copy the full SHA
    5cbe7a9 View commit details
    Browse the repository at this point in the history

  2. Really Really Really Final touch: Fix PHPStan notice

    @samsonasik
    samsonasik committed Nov 20, 2022
    Copy the full SHA
    41ad09f View commit details
    Browse the repository at this point in the history

  3. Final touch: remove unrelated change

    @samsonasik
    samsonasik committed Nov 20, 2022
    Copy the full SHA
    b683d56 View commit details
    Browse the repository at this point in the history

  4. Final touch: clean up unrelated change

    @samsonasik
    samsonasik committed Nov 20, 2022
    Copy the full SHA
    f5754cc View commit details
    Browse the repository at this point in the history

  5. Final touch: test to prove that existing addNodeBeforeNode() usage ke… 

    …ep working
    @samsonasik
    samsonasik committed Nov 20, 2022
    Copy the full SHA
    a165e83 View commit details
    Browse the repository at this point in the history

  6. add test for fixture for keep working with addNodeAfterNode() on Next… 

    … Stmt
    @samsonasik
    samsonasik committed Nov 20, 2022
    Copy the full SHA
    9561e66 View commit details
    Browse the repository at this point in the history

  7. Final touch: better fixture content

    @samsonasik
    samsonasik committed Nov 20, 2022
    Copy the full SHA
    ea43357 View commit details
    Browse the repository at this point in the history

  8. [ci-review] Rector Rectify

    @actions-user
    actions-user committed Nov 20, 2022
    Copy the full SHA
    387a5de View commit details
    Browse the repository at this point in the history