Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip __construct() in BoolReturnTypeFromStrictScalarReturnsRector #5133

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Skip __construct() in BoolReturnTypeFromStrictScalarReturnsRector #5133

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ff603d
Create skip_construct.php.inc
staabm Oct 6, 2023
a0c2962
fix
staabm Oct 6, 2023
d544ac6
use ClassMethodReturnTypeOverrideGuard
staabm Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...or/ClassMethod/BoolReturnTypeFromStrictScalarReturnsRector/Fixture/skip_construct.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\BoolReturnTypeFromStrictScalarReturnsRector\Fixture;

final class SkipConstructor
{
public function __construct()
{
return true;
Copy link
Contributor Author

@staabm staabm Oct 6, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware that having a __construct method and returning something in it does not actually make sense, but I stumbled over such a case today, and rector was adding a :bool return type on said method - which leads to a fatal error at runtime

}
}