Support @immutable phpdoc in RestoreDefaultNullToNullableTypePropertyRector #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Apr 3, 2024
|
|
||
| /** | ||
| * @immutable | ||
| */ |
There was a problem hiding this comment.
I never use Immutable attribute, but found in a project, is it possible to skip:
#[\JetBrains\PhpStorm\Immutable]and is that correct to skip that as well?
There was a problem hiding this comment.
my motivation to skip the phpdoc attribute is related to it beeing supported by phpstan.
(the rector rule when applied on classes tagged with @immutable will result in phpstan errors)
the jetbrains annotation is not supported by phpstan AFAIK, therefore not part of this PR.
I think it would be correct to support it in rector, if/when phpstan supports it
samsonasik
approved these changes
Apr 3, 2024
|
Thank you @staabm |
samsonasik
reviewed
Apr 3, 2024
|
|
||
| // @immutable annotation | ||
| $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($class); | ||
| $tags = $phpDocInfo->getTagsByName('@immutable'); |
There was a problem hiding this comment.
I am on mobile, hasByName() should actually can be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RestoreDefaultNullToNullableTypePropertyRectoralready supports a@readonlyproperty-level phpdoc. therefore I figured it should also support the class level@immutablewhich is equivalent to the nativereadonlyclass-level keyword