Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong docs for ArgumentRemoverRector #758

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Fix wrong docs for ArgumentRemoverRector #758

merged 1 commit into from
Aug 25, 2021

Conversation

DanielSiepmann
Copy link
Contributor

@DanielSiepmann DanielSiepmann commented Aug 25, 2021

The value to remove has to be enclosed as array.
The value also has to match the type. The example has a boolean true.
The example rule now matches that to prevent confusion.

Resolves: rectorphp/rector#6657

The value to remove has to be enclosed as array.
The value also has to match the type. The example has a boolean `true`.
The example rule now matches that to prevent confusion.

Resolves: #6657
@samsonasik samsonasik merged commit 991ea06 into rectorphp:main Aug 25, 2021
@samsonasik
Copy link
Member

Thank you @DanielSiepmann

@DanielSiepmann DanielSiepmann deleted the patch-1 branch August 26, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants