-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StringToArrayArgumentProcessRector
doesn't handle sprintf
command string
#188
Comments
Thank you for your report and demo link! Could you send a failing test case in a pull-request, so we have it covered in Rector? |
@TomasVotruba it seems "Create a Test" button pointed to rector-src, it not create on rector-* packages |
I see. Could you update it to point to rector-symfony if the rule is in Rector\Symfony namespace? Making it generic |
I will try. |
deployed so "Create a Test" button is now working on rector-symfony |
@samsonasik Amazing work, thank you 👍 |
Bug Report
Minimal PHP Code Causing Issue
See https://getrector.org/demo/a1df00ad-a417-4342-8040-3d2e0562e70a
Responsible rules
StringToArrayArgumentProcessRector
Expected Behavior
Probably would be easiest to skip it, as migrating the
sprintf
call could lead to wrong results and be quite tricky, if not impossible.The text was updated successfully, but these errors were encountered: