Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYMFONY_CONSTRUCTOR_INJECTION blind spot #50

Closed
Bilge opened this issue Oct 26, 2021 · 2 comments
Closed

SYMFONY_CONSTRUCTOR_INJECTION blind spot #50

Bilge opened this issue Oct 26, 2021 · 2 comments
Assignees

Comments

@Bilge
Copy link

Bilge commented Oct 26, 2021

SYMFONY_CONSTRUCTOR_INJECTION does not replace occurrences of $this->container->get('my.service');.

Notes

  • It does work for $this->get('my.service') and even $this->getContainer()->get('my.service').
  • $container is provided by ContainerAwareTrait.
@TomasVotruba
Copy link
Member

TomasVotruba commented Oct 26, 2021

Hi, thanks for reporting.

We'll need a failing test fixture for the SYMFONY_CONSTRUCTOR_INJECTION to make sure it won't happen again.

@TomasVotruba
Copy link
Member

Closing for lack of feedback. We're narrowing issues to keep focus on active and engaging contributor to keep project growing. Thank you for understanding.

Feel free to re-open with failing test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants