Rector requires phpstan 0.12.93

[devbanana]

Bug Report

Subject	Details
Rector version	0.11.42

I have phpstan 0.12.94 installed. However, when I attempt to install rector/rector with composer, it complains because it will not accept anything higher than phpstan 0.12.93. I've tried this on multiple projects.

Minimal PHP Code Causing Issue

With phpstan 0.12.94 installed, running:

composer require rector/rector —dev

throws an error.

Expected Behaviour

I should be able to install the package successfully.

[TomasVotruba]

Hi, this is expected, see composer.json:

rector/composer.json

Line 10 in 3bcd73b

"phpstan/phpstan": "0.12.93"

First, Rector needs to be tested and upgraded to newer PHPStan. In the past we had this version opened and it started to crash on PHPStan BC break. Now we got the safer way, to keep our users stable :)

Feel free to send PR to upgrade composer.json version, often it's an easy pick :)

[samsonasik]

Fixed at rectorphp/rector-src#585

[enumag]

In case someone finds this issue later, it's still possible to force installation of newer phpstan than rector allows at the given moment. For instance at the time of writing latest rector 0.11.52 requires phpstan 0.12.96 while the latest is 0.12.98. Yet I was still able to force it using this trick in composer.json:

        "phpstan/phpstan": "0.12.98 as 0.12.96",
        "rector/rector": "^0.11.52",

[enumag]

@TomasVotruba This might possibly be worth mentioning in the readme for those who know what they're doing. What do you think?

On a side note do you think phpstan version might be open again after phpstan 1.0 is out which should hopefully be more stable and not cause bc breaks anymore?

[devbanana]

This is useful, thanks for sharing.

[TomasVotruba]

The issue is conflict in shared non-prefixed PHPParser namespace. Each project has their own, so it's a race condition issue.

[enumag]

@TomasVotruba Not sure I understand. You mean there is one PHPParser installed normally as phpstan dependency and another one bundled into rector? If that's the case then why does Rector contain a copy when the parser will be there as a dependency anyway? 🤔

[enumag]

Ah yeah... rector's vendor directory contains non-prefixed nikic/php-parser as well as phpstan while also requiring them again as dependency... I understand that you need to require them in composer.json in order to prevent incompatible versions but imo they shouldn't be in the vendor directory. Ideally the vendor directory should strictly contain only prefixed packages. Is there some reason for having them there or can we remove them?

[TomasVotruba]

That's does not solve the problem.

[TomasVotruba]

Ideal solution is to unpack PHPStan and merge it's composer.json to Rector's. That way their dependencies are shared. Still requires version lock.