\Doctrine\Common\Collections\Collection mistakes?

[PhilETaylor]

Between rector/rector-src@bf2f6dd0e9a4b0abccdc345e588f1f713452848b and rector/rector-src@654b5861ca943231ffd6430062cc06d2a6f956e5 (The last day or two of changes)

something changed that now is changing all public properties to \Doctrine\Common\Collections\Collection type hinted?

[PhilETaylor]

Here is an example, a Symfony Command file, that gets changed with TypedPropertyFromToManyRelationTypeRector even though this is nothing to do with a doctrine entity or relationship

[samsonasik]

@PhilETaylor could you create failing test case PR for it? Thank you.

[PhilETaylor]

Yeah sorry, was on my todo list, but it was 3am and I needed sleep.

The PR is here in rector-doctrine as that's where the source is rectorphp/rector-doctrine#76

Hope that helps.

[TomasVotruba]

Thanks for the test case 👍 I was working on it yestereday, so it seems I broke it. I'll check the test and fix it

[TomasVotruba]

Fixed in rectorphp/rector-doctrine#77 👍

[PhilETaylor]

Awesome - thanks.