Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MyCLabsClassToEnumRector should keep traits #7241

Closed
OskarStark opened this issue Jun 16, 2022 · 1 comment · Fixed by rectorphp/rector-src#2696
Closed

MyCLabsClassToEnumRector should keep traits #7241

OskarStark opened this issue Jun 16, 2022 · 1 comment · Fixed by rectorphp/rector-src#2696
Labels
feature

Comments

@OskarStark
Copy link
Contributor

OskarStark commented Jun 16, 2022 •
edited

Feature Request

Right now, a used trait is removed when converting an MyClabs\Enum to an native PHP enum.

Reproducer

https://github.com/OskarStark/reproducer-rector-7241

Expected behaviour

The trait should still be used afterwards
@OskarStark OskarStark mentioned this issue Jun 16, 2022
Closed
@TomasVotruba TomasVotruba mentioned this issue Jul 20, 2022
Merged
@TomasVotruba
Copy link
Member

TomasVotruba commented Jul 20, 2022 •
edited

Fixed in rectorphp/rector-src#2696

Next time please send the failing fixture diretcly to the MyCLabsClassToEnumRectorTest rule, so we can resolve this sooner 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PHP 8.1] Keep use stmts in MyCLabsClassToEnumRector enum rectorphp/rector-src
2 participants
@TomasVotruba @OskarStark