-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup release vendor dir #7842
Comments
The The left over directories can be removed from build ci https://github.com/rectorphp/rector-src/blob/e11572a6f1004d905766ae88ee7ce8f667009007/.github/workflows/build_scoped_rector.yaml#L61 |
docs directory also place for rules list overview so used: https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md |
to clarify: the mentioned folders are useful in the main repo on github, but they should not be contained within the rector installation in a local project. people don't search for docs in the local vendor/ usually and all files contained in a release need to be downloaded/copied over hundreds and thousands of times in CI builds, deployments, dev-environments etc |
another question. is
actually a dev-dependency and is not required within the final release? |
tracy is used to be able to debug, see rectorphp/rector-src#3354 |
rule doc generator implements contract, used to define rule example, the one that need to be required probably https://github.com/symplify/rule-doc-generator |
Removing docs on installation only will require another process: post-install or pre-install or register to .gitattributes |
that's the way it should be done, to avoid downloading them (and avoiding the need to turn the package into a composer plugin to be able to run some post-install logic) |
Feel free to send PR to handle this 👍 |
Closing as accepted to avoid issue staling 👍 Thanks for the suggestions and PRs are still welcomed 💯 |
Feature Request
the rector release contains a bunch of not-release relevant files from dependencies within its prefixed inner-
vendor/
dirExamples:
I think there are at least some
folders, which should be stripped while the release is build.
something like these bash commands would work:
this would reduce filesize/filecount and reduce therefore installation and download/upload time via composer etc
The text was updated successfully, but these errors were encountered: