-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pre-Rector 1.0] - Faster and lighter DI container with Laravel #8120
Comments
That would be awesome. I remember one of the PRs I did in the past had to workaround slow symfony kernel caching/cache-use. Getting rid of it would be great |
Hey @TomasVotruba! Nice initiative! Maybe you can give Symfony a chance, according to the component doc it's possible to build a container by adding services :) |
@staabm Indeed, even if illuminate/container will be too lazy, I think we can easy cache around it's build :) @yguedidi Guess what I've been doing past 8 years :) Symfony DI is not suitable for CLI apps, despite marketing claims.
Any PR to improve the speed is welcomed 👍 |
@TomasVotruba I think this can be closed. |
Indeed, thanks for check 👍 Related blog post: https://getrector.com/blog/rector-018-from-symfony-container-to-laravel-and-how-to-upgrade-your-extensions |
Currently, the Symfony container pulls http-kernel and creates cached and compiled container on every test run. This leads to extreemely slow tests and downgrade of full range of symfony/* packages we don't need. I wrote about this topic here:
I want to make an experiment on performance speed, memory load and /vendor downgrade size in 2 scenarios:
If the later proves well, we can switch to it like we did in ECS last week. That resulted in 4 time faster tests:
https://twitter.com/VotrubaT/status/1683576139049058304
Let's see how the speed goes in here :)
The text was updated successfully, but these errors were encountered: