Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decouple] Remove set, rather job for PHPStorm #4521

Merged
merged 2 commits into from
Oct 31, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@
"Rector\\ConsoleDiffer\\": "packages/console-differ/src",
"Rector\\Core\\": "src",
"Rector\\DeadCode\\": "rules/dead-code/src",
"Rector\\Decouple\\": "rules/decouple/src",
"Rector\\DoctrineAnnotationGenerated\\": "packages/doctrine-annotation-generated/src",
"Rector\\DoctrineCodeQuality\\": "rules/doctrine-code-quality/src",
"Rector\\DoctrineGedmoToKnplabs\\": "rules/doctrine-gedmo-to-knplabs/src",
Expand Down Expand Up @@ -227,7 +226,6 @@
"Rector\\Compiler\\Tests\\": "compiler/tests",
"Rector\\Core\\Tests\\": "tests",
"Rector\\DeadCode\\Tests\\": "rules/dead-code/tests",
"Rector\\Decouple\\Tests\\": "rules/decouple/tests",
"Rector\\DoctrineCodeQuality\\Tests\\": "rules/doctrine-code-quality/tests",
"Rector\\DoctrineGedmoToKnplabs\\Tests\\": "rules/doctrine-gedmo-to-knplabs/tests",
"Rector\\Doctrine\\Tests\\": "rules/doctrine/tests",
Expand Down
73 changes: 1 addition & 72 deletions docs/rector_rules_overview.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# All 600 Rectors Overview
# All 599 Rectors Overview

- [Projects](#projects)
---
Expand All @@ -11,7 +11,6 @@
- [CodeQuality](#codequality) (61)
- [CodingStyle](#codingstyle) (33)
- [DeadCode](#deadcode) (41)
- [Decouple](#decouple) (1)
- [Defluent](#defluent) (8)
- [Doctrine](#doctrine) (17)
- [DoctrineCodeQuality](#doctrinecodequality) (9)
Expand Down Expand Up @@ -3479,76 +3478,6 @@ Change ternary of bool : false to && bool

<br><br>

## Decouple

### `DecoupleClassMethodToOwnClassRector`

- class: [`Rector\Decouple\Rector\ClassMethod\DecoupleClassMethodToOwnClassRector`](/rules/decouple/src/Rector/ClassMethod/DecoupleClassMethodToOwnClassRector.php)
- [test fixtures](/rules/decouple/tests/Rector/ClassMethod/DecoupleClassMethodToOwnClassRector/Fixture)

Move class method with its all dependencies to own class by method name

```php
<?php

declare(strict_types=1);

use Rector\Decouple\Rector\ClassMethod\DecoupleClassMethodToOwnClassRector;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
$services = $containerConfigurator->services();

$services->set(DecoupleClassMethodToOwnClassRector::class)
->call('configure', [[
DecoupleClassMethodToOwnClassRector::METHOD_NAMES_BY_CLASS => [
'SomeClass' => [
'someMethod' => [
'class' => 'NewDecoupledClass',
'method' => 'someRenamedMethod',
'parent_class' => 'AddedParentClass',
],
],
],
]]);
};
```


```diff
class SomeClass
{
- public function someMethod()
- {
- $this->alsoCallThis();
- }
-
- private function alsoCallThis()
- {
- }
}
```

**New file**
```php
<?php declare(strict_types=1);

class NewDecoupledClass extends AddedParentClass
{
public function someRenamedMethod(): void
{
$this->alsoCallThis();
}

private function alsoCallThis(): void
{
}
}
```

<br><br>

## Defluent

### `DefluentReturnMethodCallRector`
Expand Down
17 changes: 0 additions & 17 deletions rules/decouple/config/config.php

This file was deleted.

61 changes: 0 additions & 61 deletions rules/decouple/src/Matcher/DecoupledClassMethodMatcher.php

This file was deleted.

56 changes: 0 additions & 56 deletions rules/decouple/src/NodeFactory/ConstructorClassMethodFactory.php

This file was deleted.

61 changes: 0 additions & 61 deletions rules/decouple/src/NodeFactory/NamespaceFactory.php

This file was deleted.