Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RecurlyProvider & Elements types #205

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

artyom-88
Copy link
Contributor

@artyom-88 artyom-88 commented Mar 28, 2023

Fix TypeScript error when using RecurlyProvider & Elements in a project with TypeScript.

TS2322: Type '{ children: Element; publicKey: string; }' is not assignable to type 'IntrinsicAttributes & RecurlyOptions'.   Property 'children' does not exist on type 'IntrinsicAttributes & RecurlyOptions'

@coveralls
Copy link

Pull Request Test Coverage Report for Build 932

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.947%

Totals Coverage Status
Change from base Build 918: 0.0%
Covered Lines: 222
Relevant Lines: 222

💛 - Coveralls

@chrissrogers chrissrogers merged commit 54fc343 into recurly:main Mar 28, 2023
@chrissrogers
Copy link
Member

Thank you for the contrib!

recurly-integrations pushed a commit that referenced this pull request Aug 23, 2023
[Full Changelog](v1.2.7...v2.0.0)

**Merged Pull Requests**

- Changes demo dependency target [#214](#214) ([chrissrogers](https://github.com/chrissrogers))
- Fix RecurlyProvider & Elements types [#205](#205) ([artyom-88](https://github.com/artyom-88))
- Add dev dependency babel/plugin-transform-runtime [#200](#200) ([cyberxander90](https://github.com/cyberxander90))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants