Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tax_code to plan, add on and adjustment #120

Merged
merged 1 commit into from
Dec 4, 2014

Conversation

judith
Copy link
Contributor

@judith judith commented Nov 25, 2014

Used in tax calculations for VAT 2015 and Avalara integration taxes only.

Valid tax_code values for VAT 2015 taxes are unknown, digital and physical. Valid tax_code values for Avalara integration taxes can be found in the Avalara documentation.

Approvers: @drewish

Tests:
On a site with VAT 2015 and Avalara integration taxes enabled:

  • Create/Update a plan, add_on and adjustment with a valid tax_code and verify there isn't an error
  • Get the created/updated plan, add_on and adjustment and verify that the tax_code is returned in the results
  • Attempt to create/update a plan, add_on and adjustment with an invalid tax_code and verify that an error is returned in the results
    On a site without VAT 2015 and Avalara integration taxes enabled:
  • Get a plan, add_on and adjustment and verify that the tax_code is not returned in the results
  • Attempt to create/update a plan, add_on and adjustment with a tax_code and verify that an error is returned in the results

@drewish
Copy link

drewish commented Nov 25, 2014

Could we get that property added to the specs to demo how the serialization should work?

@judith
Copy link
Contributor Author

judith commented Nov 25, 2014

I am hesitant to add it as it is not applicable to the vast majority of users and do not want to confuse anyone by drawing attention to it...especially since sending it when those taxes are not enabled will result in an error. If those taxes are not enabled, the tax_code attribute will not appear in the data returned from the API call.

@judith judith force-pushed the jh-digital_services_vat_2015_api branch from d645377 to a9a5f25 Compare November 25, 2014 21:27
@judith judith assigned drewish and unassigned cbarton Nov 25, 2014
Used in tax calculations for VAT 2015 and
Avalara integration taxes.
@judith judith force-pushed the jh-digital_services_vat_2015_api branch from a9a5f25 to a94427c Compare December 4, 2014 18:48
@drewish
Copy link

drewish commented Dec 4, 2014

+1

drewish added a commit that referenced this pull request Dec 4, 2014
Add tax_code to plan, add on and adjustment
@drewish drewish merged commit 0a9a1ac into master Dec 4, 2014
@drewish drewish deleted the jh-digital_services_vat_2015_api branch December 4, 2014 18:54
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants