-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notes path and vat_reverse_charge_notes #128
Conversation
d7164eb
to
9041df3
Compare
/** | ||
* Does a mass assignment on this resource's values | ||
* | ||
* @parameter array array of values to set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
array is there twice.
f237f6c
to
9f44f83
Compare
/** | ||
* Updates the notes fields of the subscription without generating a SubscriptionChange. | ||
* | ||
* $notes - array any of the note fields (customer_notes, terms_and_conditions, vat_reverse_charge_notes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of the docs are using the @param PHP doc style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also like to reword this to indicate that these are the allowed key names
9f44f83
to
45266c6
Compare
Adding vat_reverse_charge_notes to Subscription and Invoice. Also adding updateNotes() method with calls the new PUT /notes path.
45266c6
to
c7fab13
Compare
+1 |
…e_charge_notes Update notes path and vat_reverse_charge_notes
This adds the new
update_notes
path forSubscription
and addsvat_reverse_charge_notes
toInvoice
.Relies on #115
Approvers: @drewish