Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notes path and vat_reverse_charge_notes #128

Merged
merged 1 commit into from
Jan 8, 2015

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Jan 7, 2015

This adds the new update_notes path for Subscription and adds vat_reverse_charge_notes to Invoice.

Relies on #115

Approvers: @drewish

@bhelx bhelx force-pushed the update_notes_path_and_vat_reverse_charge_notes branch 2 times, most recently from d7164eb to 9041df3 Compare January 7, 2015 22:05
/**
* Does a mass assignment on this resource's values
*
* @parameter array array of values to set
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array is there twice.

@bhelx bhelx force-pushed the update_notes_path_and_vat_reverse_charge_notes branch 2 times, most recently from f237f6c to 9f44f83 Compare January 7, 2015 23:09
@bhelx bhelx changed the title [WIP] Update notes path and vat_reverse_charge_notes Update notes path and vat_reverse_charge_notes Jan 7, 2015
/**
* Updates the notes fields of the subscription without generating a SubscriptionChange.
*
* $notes - array any of the note fields (customer_notes, terms_and_conditions, vat_reverse_charge_notes)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the docs are using the @param PHP doc style

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to reword this to indicate that these are the allowed key names

@bhelx bhelx force-pushed the update_notes_path_and_vat_reverse_charge_notes branch from 9f44f83 to 45266c6 Compare January 8, 2015 21:01
Adding vat_reverse_charge_notes to Subscription and Invoice.
Also adding updateNotes() method with calls the new PUT /notes path.
@bhelx bhelx force-pushed the update_notes_path_and_vat_reverse_charge_notes branch from 45266c6 to c7fab13 Compare January 8, 2015 21:04
@drewish
Copy link

drewish commented Jan 8, 2015

+1

drewish added a commit that referenced this pull request Jan 8, 2015
…e_charge_notes

Update notes path and vat_reverse_charge_notes
@drewish drewish merged commit 0161ef8 into master Jan 8, 2015
@drewish drewish deleted the update_notes_path_and_vat_reverse_charge_notes branch January 8, 2015 21:39
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants