-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support open amount and line item refunds #133
Conversation
0c78172
to
b60a4c0
Compare
129ec0c
to
537e5dc
Compare
public function refundAmount($amount_in_cents) { | ||
$uri = $this->uri() . '/refund'; | ||
|
||
$invoice = new self(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any objection to naming this $refund
or $refund_invoice
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, sounds good. That's what I am doing in other branch. Will change.
3406cab
to
484185f
Compare
return new DOMDocument("1.0"); | ||
} | ||
|
||
public function renderXML($doc) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this whole refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
5c56093
to
cce6048
Compare
I think we need to ensure that the adjustment has an invoice. If you try to refund an un-invoiced charge:
|
Good point |
bd88e23
to
d5946fc
Compare
d5946fc
to
f5b7790
Compare
Support open amount and line item refunds
+1 |
This pull request is to support both open amount and line item refunds on
Invoice
.Approvers: @drewish
Testing
Open Amount:
Line Item [WIP]: