Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding setup_fee_accounting_code #179

Merged
merged 1 commit into from
Aug 21, 2015
Merged

Adding setup_fee_accounting_code #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Recurly PHP Client Library CHANGELOG

## Unreleased
* Added `setup_fee_accounting_code` to `Plan`

## Version 2.4.5 (August 3, 2015)

* Added `duration`, `temporal_unit`, & `temporal_amount` to `Coupon` [#171](https://github.com/recurly/recurly-client-php/pull/171)
Expand Down
1 change: 1 addition & 0 deletions Tests/Recurly/Plan_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public function testGetPlan() {
$this->assertEquals(15, $plan->trial_interval_length);
$this->assertEquals('days', $plan->trial_interval_unit);
$this->assertEquals(6, $plan->total_billing_cycles);
$this->assertEquals("Setup Fee AC", $plan->setup_fee_accounting_code);

$this->assertInstanceOf('Recurly_CurrencyList', $plan->unit_amount_in_cents);
$this->assertEquals(1000, $plan->unit_amount_in_cents['USD']->amount_in_cents);
Expand Down
1 change: 1 addition & 0 deletions Tests/fixtures/plans/show-200.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Content-Type: application/xml; charset=utf-8
<trial_interval_unit>days</trial_interval_unit>
<total_billing_cycles type="integer">6</total_billing_cycles>
<accounting_code nil="nil"></accounting_code>
<setup_fee_accounting_code>Setup Fee AC</setup_fee_accounting_code>
<created_at type="datetime">2011-04-19T07:00:00Z</created_at>
<tax_exempt type="boolean">true</tax_exempt>
<unit_amount_in_cents>
Expand Down
3 changes: 2 additions & 1 deletion lib/recurly/plan.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ public static function init()
'bypass_hosted_confirmation','unit_name','payment_page_tos_link',
'plan_interval_length','plan_interval_unit','trial_interval_length',
'trial_interval_unit','unit_amount_in_cents','setup_fee_in_cents',
'total_billing_cycles','accounting_code','tax_exempt','tax_code'
'total_billing_cycles','accounting_code','setup_fee_accounting_code',
'tax_exempt','tax_code'
);
Recurly_Plan::$_nestedAttributes = array(
'add_ons'
Expand Down