Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupon lists require a parent object #243

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Conversation

drewish
Copy link

@drewish drewish commented Jun 24, 2016

The coupon listings all require a parent object. Both of these functions that are being removed generate calls to invalid paths and result in 404s:

Recurly_CouponRedemptionList::get()->count();
Recurly_UniqueCouponCodeList::get()->count();

In comparison these will return data:

$accountCode = Recurly_AccountList::get()->current()->account_code;
$invoiceNumber = Recurly_InvoiceList::get()->current()->invoice_number;
$subscriptionUuid = Recurly_SubscriptionList::get()->current()->uuid;
Recurly_CouponRedemptionList::getForAccount($accountCode, $options)->count();
Recurly_CouponRedemptionList::getForInvoice($invoiceNumber, $options)->count();
Recurly_CouponRedemptionList::getForSubscription($subscriptionUuid, $options)->count();

Recurly_UniqueCouponCodeList::get($subscriptionCouponCode, $options);

@bhelx
Copy link
Contributor

bhelx commented Jul 1, 2016

👍

@bhelx bhelx merged commit 88f948b into master Jul 1, 2016
@bhelx bhelx deleted the correct-coupon-listing branch July 1, 2016 21:40
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants