-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new pagination #249
Conversation
$this->_loadRecordCount($response); | ||
$this->_loadLinks($response); | ||
$this->_href = isset($this->_links['start']) ? $this->_links['start'] : $uri; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a bug where we were rewinding to the second page rather than the first.
ca87899
to
95da354
Compare
@@ -4,7 +4,12 @@ | |||
|
|||
* Added support for `original_transaction` to `Recurly_Transaction` [#238](https://github.com/recurly/recurly-client-php/pull/238) | |||
* Added `Recurly_AccountBalance` [#239](https://github.com/recurly/recurly-client-php/pull/239) | |||
* Print warnings when using a deprecated version of the API. | |||
* Print warnings when using a deprecated version of the API. [#250](https://github.com/recurly/recurly-client-php/pull/250): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized this one didn't have a PR links so I just stuck it in here while rebasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Good enough
Any status on when this will be merged into master? |
@bobalbert I will be finishing review today |
@bobalbert but it'll probably be a couple days before the api-2.3 branch is merged. there's at least one more PR we need to add. |
@drewish thanks for the info. I'll manually merge over this one item into my version development version. I'll look for the full merge later this week hopefully. |
👍 |
Here's the testing code I was using to check this out