Call Recurly_Resource's constructor #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP doesn't call parent constructors automagically, so if you override it you need to call
parent::__construct()
yourself.There's sort of a side question of should we maintain the same interface...
Recurly_Subscription
was passing$href
and$client
up but none of the others were andRecurly_Account
has a totally different thing where it'll accept$accountCode
. So I think we could go either way but it'd be nice to pick one.