Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gift card purchase, preview, & get #254

Closed
wants to merge 3 commits into from

Conversation

shulmang
Copy link

@shulmang shulmang commented Jun 23, 2016

Adds support for gift card purchasing

@shulmang shulmang added the WIP label Jun 23, 2016
@shulmang shulmang changed the title add gift card purchase [MT-1624] add gift card purchase Jun 23, 2016
@@ -127,7 +127,7 @@ class Resource
# e.message # => "Can't find Account with account_code = tortuga"
# end
class NotFound < API::NotFound
def initialize message
def initialize(message)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but is there any way you could put these changes in their own commit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, @bhelx . Should be all set.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. It's a minor thing but helpful for keeping blames clean.

@shulmang shulmang force-pushed the shulmang/mt1624/add_gift_card_purchase branch 2 times, most recently from e19af67 to 0f80527 Compare June 30, 2016 22:22
@shulmang shulmang added new feature and removed WIP labels Jul 5, 2016
@bhelx bhelx changed the title [MT-1624] add gift card purchase Add gift card purchase Jul 5, 2016
@shulmang shulmang force-pushed the shulmang/mt1624/add_gift_card_purchase branch from 0f80527 to f5df683 Compare July 11, 2016 20:13
@shulmang shulmang changed the title Add gift card purchase Add gift card purchase, preview, & get Jul 11, 2016
@bhelx
Copy link
Contributor

bhelx commented Jul 25, 2016

Closing in favor of #257

@bhelx bhelx closed this Jul 25, 2016
@aaron-junot aaron-junot deleted the shulmang/mt1624/add_gift_card_purchase branch September 25, 2018 16:42
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
@bhelx bhelx unassigned cookrn Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants