Upgrade Braintree SDK and 3DS params

recurly · Apr 1, 2024 · f15bbf6 · f15bbf6
1 parent dbe1dbc
commit f15bbf6
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 12 deletions.
diff --git a/lib/const/gateway-constants.js b/lib/const/gateway-constants.js
@@ -1 +1 @@
-export const BRAINTREE_CLIENT_VERSION = '3.96.1';
+export const BRAINTREE_CLIENT_VERSION = '3.100';
diff --git a/lib/recurly/risk/three-d-secure/strategy/braintree.js b/lib/recurly/risk/three-d-secure/strategy/braintree.js
@@ -34,6 +34,10 @@ export default class BraintreeStrategy extends ThreeDSecureStrategy {
     return this.actionToken.transaction.amount;
   }
 
+  get billingInfo () {
+    return this.actionToken.billing_info;
+  }
+
   get bin () {
     return this.actionToken.three_d_secure.params.bin;
   }
@@ -51,7 +55,32 @@ export default class BraintreeStrategy extends ThreeDSecureStrategy {
     this.whenReady(() => {
       debug('Attempting to load braintree');
 
-      const { braintree, braintreeClientToken, amount, nonce, bin } = this;
+      const { braintree, braintreeClientToken, amount, nonce, bin, billingInfo } = this;
+
+      const verifyCardOptions = {
+        amount: amount,
+        nonce: nonce,
+        bin: bin,
+        challengeRequested: true,
+        collectDeviceData: true,
+        onLookupComplete: (data, next) => {
+          next();
+        }
+      };
+
+      if(billingInfo != null) {
+        verifyCardOptions.billingAddress = {
+          givenName: billingInfo.first_name,
+          surname: billingInfo.last_name,
+          phoneNumber: billingInfo.phone,
+          streetAddress: billingInfo.address1,
+          extendedAddress: billingInfo.address2,
+          locality: billingInfo.city,
+          region: billingInfo.state,
+          postalCode: billingInfo.zip,
+          countryCodeAlpha2: billingInfo.country
+        };
+      }
 
       braintree.client.create({
         authorization: braintreeClientToken
@@ -61,15 +90,9 @@ export default class BraintreeStrategy extends ThreeDSecureStrategy {
           version: 2
         });
       }).then(threeDSecureInstance => {
-        return threeDSecureInstance.verifyCard({
-          amount: amount,
-          nonce: nonce,
-          bin: bin,
-          challengeRequested: true,
-          onLookupComplete: (data, next) => {
-            next();
-          }
-        });
+        return threeDSecureInstance.verifyCard(
+          verifyCardOptions,
+        );
       }).then(({ nonce: paymentMethodNonce }) => this.emit('done', { paymentMethodNonce }))
         .catch(cause => this.threeDSecure.error('3ds-auth-error', { cause }));
     });

diff --git a/test/unit/apple-pay.test.js b/test/unit/apple-pay.test.js
@@ -64,7 +64,7 @@ ApplePaySessionStub.canMakePayments = () => true;
 
 const getBraintreeStub = () => ({
   client: {
-    VERSION: '3.96.1',
+    VERSION: '3.100',
     create: sinon.stub().resolves('CLIENT'),
   },
   dataCollector: {

diff --git a/test/unit/risk/three-d-secure/strategy/braintree.test.js b/test/unit/risk/three-d-secure/strategy/braintree.test.js
@@ -84,6 +84,7 @@ describe('BraintreeStrategy', function () {
           nonce: "test-braintree-nonce",
           bin: "test-braintree-bin",
           challengeRequested: true,
+          collectDeviceData: true,
           onLookupComplete: sinon.match.func
         }));