Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize use of masks #99

Closed
bengioe opened this issue Jul 17, 2023 · 1 comment
Closed

Harmonize use of masks #99

bengioe opened this issue Jul 17, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bengioe
Copy link
Collaborator

bengioe commented Jul 17, 2023

Masks are currently used somewhat ad-hoc here and there, in particular:

  • GraphSampler explicitly uses them, but it should be abstracted away
  • GraphTransformerGFN and derivatives end up applying masks themselves, but this feels like the "wrong" place

Instead, it would be good for GraphActionCategorical to do all the accounting of masks and mask-related code.
@bengioe bengioe added enhancement New feature or request good first issue Good for newcomers labels Jul 17, 2023
@bengioe
Copy link
Collaborator Author

bengioe commented May 27, 2024

This has been addressed in #129 🎉

@bengioe bengioe closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bengioe