Adds ActionIndex and Harmonize use of action-masks #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* renamed masks in GraphActionCategorical to action_mask (to avoid confusion with done-masking, molecule validity masking, goal-conditioning masking, etc.) * made logits and masks private attributes of GraphActionCategorical * remove _mask() application from GraphTransformerFragEnvelopeQL and GraphTransformerGFN * removed masking from GraphSampler (masks applied in property setters of GraphActionCategorical._logits)
…-masking i.e. masked_logit * 0. -> 0. (un-masked))
… outside the class definition and avoid silent bugs due to unintended default configs
julienroyd
force-pushed
the
julien-harmonize-use-of-masks
branch
from
ce4ec3d
to
5f953c6
Compare
This reverts commit b3ee035.
|
Can reproduce previous results with goal-conditioning and 4 objectives: |
bengioe
approved these changes
Apr 11, 2024
This was referenced May 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masks were used somewhat ad-hoc here and there. Here we centralise masking in GraphActionCategorical(), specifically:
We also replaced the action-tuples
Tuple[int, int, int]action type, row and column by a named-tupleActionIndexto the code and typing more intuitive and readable.