Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ranges always max inclusive #16

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

jackdotink
Copy link
Member

This change removes the syntax 1..=10 and makes 1..10 include 10.

closes #9

Co-authored-by: Sasial <44125644+sasial-dev@users.noreply.github.com>
Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sasial-dev sasial-dev merged commit 0bc82cf into main Dec 19, 2023
2 checks passed
@sasial-dev sasial-dev deleted the zap/max-range-inclusive branch December 19, 2023 22:36
@sasial-dev sasial-dev linked an issue Dec 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] des ranges aren't max inclusive [FEAT] make range max inclusive by default
2 participants