New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPSTREAM] Get Maximum Available GPU using Prometheus Data #57
Conversation
/hold until upstream PR is merged. Live Build: quay.io/modh/rhods-operator-live-catalog:1.10.0-rhods-3182 |
@lugi0 Tagging early for test implementation. This is not merged in upstream yet. |
@VaishnaviHire thanks. Is this going to return the maximum number of GPUs in a single node? I remember there were discussions around having separate counts for separate nodes and letting the user pick and choose. |
This is just for the maximum number of GPUs in a node. The difference from the previous implementation is that now the maximum number of GPU will be updated to display just the |
Understood, so the dropdown will be dinamically updated to reflect how many GPUs are still available for use? |
Yes. It should not have any effect in case of no taint, I have added a check here https://github.com/red-hat-data-services/jupyterhub-singleuser-profiles/pull/57/files#diff-98a012f258f1bc42077e3b4bd199d163917d2a7d7e9a864ea3ac9f0ea3accc84R202 to only query Prometheus when |
What I had in mind was slightly different, i.e. the gpu operator is present but no taint was applied to the gpu node when provisioning it on the cluster. I think it's a corner case we don't even want to explicitly support, so it should be fine either way. |
(cherry picked from commit 22ff067)
83f0d35
to
b340688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This worked perfectly from the live build quay.io/modh/rhods-operator-live-catalog:1.10.0-rhods-3182
(cherry picked from commit 5a20fb9)
[UPSTREAM]
has been prepended to the commit message