Add a new logic related to version and 1 more namespace to gather dat… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm Worked well for me. |
VaishnaviHire
approved these changes
Aug 24, 2022
|
Tested with custom built image : cc: @bdattoma |
bdattoma
reviewed
Aug 24, 2022
Jooho
commented
Aug 24, 2022
bdattoma
reviewed
Aug 25, 2022
|
is there a Jira related to this PR? @Jooho @VaishnaviHire |
|
|
could you please generate a new build for the must gather image? @pablofelix is gonna follow this topic |
Updated the build. |
…a 'rhods-notebooks' Signed-off-by: jooho <jlee@redhat.com>
|
@VaishnaviHire could you please merge it and build an official must-gather image? |
|
@LaVLaS I am unable to merge this. Do you have access to merge this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2
Signed-off-by: jooho jlee@redhat.com