Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide 'GPU Computing' tutorial behind a feature flag #150

Merged

Conversation

jeff-phillips-18
Copy link

@jeff-phillips-18 jeff-phillips-18 commented Sep 23, 2021

Fixes:
Jira: https://issues.redhat.com/browse/RHODS-1918

Analysis / Root cause:
GPU selection is not available so the tutorials about GPU computing (i.e., GPU Computing in Python with Numba) should be hidden in the "Resources" tab of RHODS

Solution Description:
Mark the GPU Computing in Python with Numba tutorial as requiring a feature flag of gpu-computing which is set to false.

  • - [x] The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-1918
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

Copy link

@cfchase cfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit cae411c into red-hat-data-services:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants