Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable access to cluster manager #151

Conversation

jeff-phillips-18
Copy link

@jeff-phillips-18 jeff-phillips-18 commented Sep 24, 2021

Fixes:
Jira: https://issues.redhat.com/browse/RHODS-1945

The sandbox users will not have access to cluster management and therefore the link to Cluster manager console is useless.

Analysis / Root cause:
The dashboard only checks for the availability of the cluster manager it does not know if the user has access.

Solution Description:
Add a config setting to disable access to the cluster manager.

Example config map with disablement:

kind: ConfigMap
apiVersion: v1
metadata:
  name: odh-dashboard-config
  namespace: redhat-ods-applications
  uid: 3b8092d5-94b0-45d4-b010-1bd88e5968ff
  resourceVersion: '100273'
  creationTimestamp: '2021-09-24T12:37:29Z'
  managedFields:
    - manager: Mozilla
      operation: Update
      apiVersion: v1
      time: '2021-09-24T12:37:29Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:data':
          .: {}
          'f:disableClusterManager': {}
          'f:disableInfo': {}
          'f:disableSupport': {}
          'f:enablement': {}
data:
  disableClusterManager: 'true'
  disableInfo: 'false'
  disableSupport: 'false'
  enablement: 'true'
  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-1945
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

Copy link

@cfchase cfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit d23244f into red-hat-data-services:master Sep 24, 2021
Copy link

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a couple of warnings on hook dependency for useMemo were thrown around the new ref

... = dashboardConfig.disableClusterManager ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants