Show disabled applications on Enabled page #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-phillips-18
requested changes
Jan 27, 2022
| ): Promise<{ success: boolean; error: string }> => { | ||
| const query = request.query as { [key: string]: string }; | ||
| const coreV1Api = fastify.kube.coreV1Api; | ||
| const enabledAppsConfigMapName = 'odh-enabled-applications-config'; |
There was a problem hiding this comment.
This should probably be different for upstream vs downstream. Either define a constant in constants.ts so it is easier to change w/o merge conflicts or (better) in the .env file.
dlabaj
approved these changes
Jan 28, 2022
|
@DaoDaoNoCode Do we have an upstream PR for this? |
|
opendatahub-io#108 upstream PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[UPSTREAM]has been prepended to the commit message