Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPSTREAM]: Add culler timeout feature and save button #207

Merged
merged 1 commit into from
Apr 14, 2022
Merged

[UPSTREAM]: Add culler timeout feature and save button #207

merged 1 commit into from
Apr 14, 2022

Conversation

DaoDaoNoCode
Copy link

@DaoDaoNoCode DaoDaoNoCode commented Apr 13, 2022 •
edited

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s): https://issues.redhat.com/browse/RHODS-3158
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)
  • The developer has manually tested the changes and verified that the changes work.

@crobby
Copy link

crobby commented Apr 13, 2022

Live build: quay.io/croberts/rhods-operator-live-catalog:1.9.0-0-jira-2324-31
Seems to be working for me

@crobby crobby requested a review from lugi0 April 14, 2022 11:51
lugi0
lugi0 approved these changes Apr 14, 2022
View reviewed changes
Copy link

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in a live build, lgtm

@crobby crobby self-requested a review April 14, 2022 13:36
@crobby crobby merged commit b12ff21 into red-hat-data-services:master Apr 14, 2022
@crobby crobby mentioned this pull request Apr 14, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobby crobby crobby approved these changes

@lugi0 lugi0 lugi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DaoDaoNoCode @crobby @lugi0